From 0bba383f3d69b8cc4c18d3bc1115f1027981e8b0 Mon Sep 17 00:00:00 2001 From: Muhammad Danish <88161975+mdanish-kh@users.noreply.github.com> Date: Thu, 8 Aug 2024 05:31:07 +0500 Subject: [PATCH 1/2] Fix tense for resource string --- src/WingetCreateCLI/Commands/NewCommand.cs | 2 +- src/WingetCreateCLI/Commands/UpdateCommand.cs | 4 ++-- src/WingetCreateCLI/Properties/Resources.Designer.cs | 6 +++--- src/WingetCreateCLI/Properties/Resources.resx | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/WingetCreateCLI/Commands/NewCommand.cs b/src/WingetCreateCLI/Commands/NewCommand.cs index 7968567b..169ff5e7 100644 --- a/src/WingetCreateCLI/Commands/NewCommand.cs +++ b/src/WingetCreateCLI/Commands/NewCommand.cs @@ -242,7 +242,7 @@ public override async Task Execute() bool populated = await this.GitHubClient.PopulateGitHubMetadata(manifests, this.Format.ToString()); if (populated) { - Logger.InfoLocalized(nameof(Resources.PopulatingGitHubMetadata_Message)); + Logger.InfoLocalized(nameof(Resources.PopulatedGitHubMetadata_Message)); } } } diff --git a/src/WingetCreateCLI/Commands/UpdateCommand.cs b/src/WingetCreateCLI/Commands/UpdateCommand.cs index 58dbc567..d7f5bf0c 100644 --- a/src/WingetCreateCLI/Commands/UpdateCommand.cs +++ b/src/WingetCreateCLI/Commands/UpdateCommand.cs @@ -472,7 +472,7 @@ public async Task UpdateManifestsAutonomously(Manifests manifests) bool populated = await this.GitHubClient.PopulateGitHubMetadata(manifests, this.Format.ToString()); if (populated) { - Logger.InfoLocalized(nameof(Resources.PopulatingGitHubMetadata_Message)); + Logger.InfoLocalized(nameof(Resources.PopulatedGitHubMetadata_Message)); } } } @@ -943,7 +943,7 @@ private async Task UpdateManifestsInteractively(Manifests manifests) bool populated = await this.GitHubClient.PopulateGitHubMetadata(manifests, this.Format.ToString()); if (populated) { - Logger.InfoLocalized(nameof(Resources.PopulatingGitHubMetadata_Message)); + Logger.InfoLocalized(nameof(Resources.PopulatedGitHubMetadata_Message)); } } } diff --git a/src/WingetCreateCLI/Properties/Resources.Designer.cs b/src/WingetCreateCLI/Properties/Resources.Designer.cs index c97d7cf7..a8c383b1 100644 --- a/src/WingetCreateCLI/Properties/Resources.Designer.cs +++ b/src/WingetCreateCLI/Properties/Resources.Designer.cs @@ -2311,11 +2311,11 @@ public static string Platform_KeywordDescription { } /// - /// Looks up a localized string similar to GitHub URL detected. The CLI will automatically fill some manifests fields.. + /// Looks up a localized string similar to GitHub URL detected. The CLI has automatically filled some manifests fields.. /// - public static string PopulatingGitHubMetadata_Message { + public static string PopulatedGitHubMetadata_Message { get { - return ResourceManager.GetString("PopulatingGitHubMetadata_Message", resourceCulture); + return ResourceManager.GetString("PopulatedGitHubMetadata_Message", resourceCulture); } } diff --git a/src/WingetCreateCLI/Properties/Resources.resx b/src/WingetCreateCLI/Properties/Resources.resx index 880c8a72..621864a1 100644 --- a/src/WingetCreateCLI/Properties/Resources.resx +++ b/src/WingetCreateCLI/Properties/Resources.resx @@ -1374,8 +1374,8 @@ Could not populate manifest metadata through GitHub's API. - - GitHub URL detected. The CLI will automatically fill some manifests fields. + + GitHub URL detected. The CLI has automatically filled some manifests fields. Date to be used when updating the release date field. Expected format is "YYYY-MM-DD". From 690621460c8e34ac0a78b279fe8d0cf163e60dab Mon Sep 17 00:00:00 2001 From: Muhammad Danish <88161975+mdanish-kh@users.noreply.github.com> Date: Thu, 8 Aug 2024 05:43:27 +0500 Subject: [PATCH 2/2] singular --- src/WingetCreateCLI/Properties/Resources.Designer.cs | 2 +- src/WingetCreateCLI/Properties/Resources.resx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/WingetCreateCLI/Properties/Resources.Designer.cs b/src/WingetCreateCLI/Properties/Resources.Designer.cs index a8c383b1..8cea1df8 100644 --- a/src/WingetCreateCLI/Properties/Resources.Designer.cs +++ b/src/WingetCreateCLI/Properties/Resources.Designer.cs @@ -2311,7 +2311,7 @@ public static string Platform_KeywordDescription { } /// - /// Looks up a localized string similar to GitHub URL detected. The CLI has automatically filled some manifests fields.. + /// Looks up a localized string similar to GitHub URL detected. The CLI has automatically filled some manifest fields.. /// public static string PopulatedGitHubMetadata_Message { get { diff --git a/src/WingetCreateCLI/Properties/Resources.resx b/src/WingetCreateCLI/Properties/Resources.resx index 621864a1..0458ff00 100644 --- a/src/WingetCreateCLI/Properties/Resources.resx +++ b/src/WingetCreateCLI/Properties/Resources.resx @@ -1375,7 +1375,7 @@ Could not populate manifest metadata through GitHub's API. - GitHub URL detected. The CLI has automatically filled some manifests fields. + GitHub URL detected. The CLI has automatically filled some manifest fields. Date to be used when updating the release date field. Expected format is "YYYY-MM-DD".