From bee869935fec6507d07cd8db941edb5e6840be6d Mon Sep 17 00:00:00 2001 From: Doug Horner Date: Thu, 4 Sep 2025 01:02:58 -0400 Subject: [PATCH] Potential fix for code scanning alert no. 4: Uncontrolled command line Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --- create-a-container/server.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/create-a-container/server.js b/create-a-container/server.js index 5b97cc62..6d5db713 100644 --- a/create-a-container/server.js +++ b/create-a-container/server.js @@ -1,7 +1,7 @@ const express = require('express'); const bodyParser = require('body-parser'); const session = require('express-session'); -const { spawn, exec } = require('child_process'); +const { spawn, exec, execFile } = require('child_process'); const path = require('path'); const crypto = require('crypto'); const fs = require('fs'); // Added fs module @@ -36,7 +36,7 @@ app.get('/form.html', (req, res) => { app.post('/login', (req, res) => { const { username, password } = req.body; - exec(`node /root/bin/js/runner.js authenticateUser ${username} ${password}`, (err, stdout) => { + execFile('node', ['/root/bin/js/runner.js', 'authenticateUser', username, password], (err, stdout) => { if (err) { console.error("Login script execution error:", err); return res.status(500).json({ error: "Server error during authentication." });