From 9da014ef9dc009cbc3410ea6b1093d5056a3ab81 Mon Sep 17 00:00:00 2001
From: Isaac Devine <isaac@devinesystems.co.nz>
Date: Thu, 27 Mar 2014 20:26:30 +1300
Subject: [PATCH] Allow implementors to control network syncing

Allow implementors to control the network syncing notification by
analyzing the ContentValues that are used to update or insert the
record. Deletes are always treated as not requiring a sync as by the
time the delete is completed the sync adapter will find it hard to sync
now deleted data.
---
 .../content/SimpleContentProvider.java        | 23 +++++++++++++++----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/src/edu/mit/mobile/android/content/SimpleContentProvider.java b/src/edu/mit/mobile/android/content/SimpleContentProvider.java
index 839fc87..d94dd85 100644
--- a/src/edu/mit/mobile/android/content/SimpleContentProvider.java
+++ b/src/edu/mit/mobile/android/content/SimpleContentProvider.java
@@ -453,7 +453,8 @@ public int delete(Uri uri, String selection, String[] selectionArgs) {
         }
         final int count = mDBHelperMapper.delete(match, this, db, uri, selection, selectionArgs);
 
-        getContext().getContentResolver().notifyChange(uri, null);
+        // Never need to synchronize deletes.
+        getContext().getContentResolver().notifyChange(uri, null, false);
 
         return count;
     }
@@ -557,7 +558,7 @@ public Uri insert(Uri uri, ContentValues values) {
         }
         final Uri newUri = mDBHelperMapper.insert(match, this, db, uri, values);
         if (newUri != null) {
-            getContext().getContentResolver().notifyChange(uri, null);
+            getContext().getContentResolver().notifyChange(uri, null, shouldSyncChanges(values));
         }
         return newUri;
     }
@@ -579,17 +580,19 @@ public int bulkInsert(Uri uri, ContentValues[] values) {
         int numSuccessfulAdds = 0;
         db.beginTransaction();
         try {
+        	boolean syncToNetwork = false;
 
             for (final ContentValues cv : values) {
-                final Uri newUri = mDBHelperMapper.insert(match, this, db, uri, cv);
+            	final Uri newUri = mDBHelperMapper.insert(match, this, db, uri, cv);
                 if (newUri != null) {
                     numSuccessfulAdds++;
+                    syncToNetwork = syncToNetwork || shouldSyncChanges(cv);
                 }
             }
             db.setTransactionSuccessful();
 
             if (numSuccessfulAdds > 0) {
-                getContext().getContentResolver().notifyChange(uri, null);
+                getContext().getContentResolver().notifyChange(uri, null, syncToNetwork);
             }
         } finally {
             db.endTransaction();
@@ -647,12 +650,22 @@ public int update(Uri uri, ContentValues values, String selection, String[] sele
         final int changed = mDBHelperMapper.update(match, this, db, uri, values, selection,
                 selectionArgs);
         if (changed != 0) {
-            getContext().getContentResolver().notifyChange(uri, null);
+            getContext().getContentResolver().notifyChange(uri, null, shouldSyncChanges(values));
         }
         return changed;
     }
 
     // ///////////////////// private methods
+    
+    /**
+     * Given the values, determine if the network sync should be called.
+     * @param values
+     * @return true if changes should be synced to network.
+     */
+    protected boolean shouldSyncChanges(ContentValues values) {
+    	return true;
+    }
+    
     /**
      * Generates a name for the database from the content provider.
      *