This repository was archived by the owner on Jul 31, 2020. It is now read-only.
Adds a getter for participants, groups and scenes#78
Merged
SimonSchick merged 2 commits intomixer:masterfrom Jun 20, 2017
cactysman:enhancement-participantList
Merged
Adds a getter for participants, groups and scenes#78SimonSchick merged 2 commits intomixer:masterfrom cactysman:enhancement-participantList
SimonSchick merged 2 commits intomixer:masterfrom
cactysman:enhancement-participantList
Conversation
Contributor
|
I prefer Not sure what others think though |
Contributor
|
I agree with @ProbablePrime, I think getScenes and getParticipants keeps it consistent with the getScene and getGroup methods. I'm not so much against _private variables, but I also like to keep things consistent with the style so it's easier to read later. |
ProbablePrime
approved these changes
Jun 19, 2017
SimonSchick
approved these changes
Jun 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... because there was no nice way to do that before, other than either querying the server again or manually storing a list of (session|group|participant)IDs.