Skip to content

Commit 50ebadc

Browse files
committed
docs: improve readability of contribute.md (issue #37)
Signed-off-by: Reed <reedjmerrill@gmail.com>
1 parent 1bf435d commit 50ebadc

File tree

1 file changed

+62
-64
lines changed

1 file changed

+62
-64
lines changed

docs/developer-guide/contribute.md

Lines changed: 62 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -33,106 +33,102 @@ There are plenty of ways to contribute to an open source project, even without c
3333
Therefore, anyone who is interested in this project is very welcome to contribute in one of the following ways:
3434

3535
1. Using `MLSysOps framework`. Try it out yourself and let us know your experience. Did everything work well? Were the instructions clear?
36-
2. Improve or suggest changes to the documentation of the project. Documentation is very important for every project, hence any ideas on how to improve the documentation to make it more clear are more than welcome.
37-
3. Request new features. Any proposals for improving or adding new features are very welcome.
38-
4. Find a bug and report it. Bugs are everywhere and some are hidden very well. As a result, we would really appreciate it if someone found a bug and reported it to the maintainers.
39-
5. Make changes to the code. Improve the code, add new functionalities and make `MLSysOps framework` even more useful.
36+
2. Improve or suggest changes to the documentation of the project. Documentation is a very important part of every project, hence any ideas on how to make it more clear are more than welcome.
37+
3. Request new features. Any proposals for improving existing features or adding new ones are very welcome.
38+
4. Find a bug and report it. Bugs are everywhere and some are hidden very well. As a result, if you find a bug, we would really appreciate it if you reported it to the maintainers.
39+
5. Make changes to the code. Improve the code, add new functionality, and make `MLSysOps framework` even more useful.
4040

4141
## Opening an issue
4242

4343
We use Github issues to track bugs and requests for new features.
44-
Anyone is welcome to open a new issue, which is either related to a bug or a request for a new feature.
44+
Anyone is welcome to open a new issue, either to report a bug or to request a new feature.
4545

4646
### Reporting bugs
4747

48-
In order to report a bug or misbehavior in `MLSysOps framework`, a user can open a new issue explaining the problem.
49-
For the time being, we do not use any strict template for reporting any issues.
50-
However, in order to easily identify and fix the problem, it would be very helpful to provide enough information.
51-
In that context, when opening a new issue regarding a bug, we kindly ask you to:
48+
To report a bug or misbehavior in `MLSysOps framework`, a user can open a new issue explaining the problem.
49+
For the time being, we do not have a strict template for reporting issues, however, it is important that enough information is provided for the problem to be easily identified and resolved.
50+
To that end, when opening a new issue regarding a bug, we kindly ask you to:
5251

5352
- Mark the issue with the bug label
5453
- Provide the following information:
54+
1. A short description of the bug.
55+
2. The respective logs both from the output and `containerd`.
56+
3. Framework's version manifest (either the commit hash or the version manifest file).
57+
4. The execution environment (CPU architecture, VMM etc.).
58+
5. Any particular steps to reproduce the issue.
5559

56-
1. A short description of the bug.
57-
2. The respective logs both from the output and containerd.
58-
3. Framework's version manifest (either the commit hash or the version manifest file).
59-
4. The execution environment (CPU architecture, VMM etc.).
60-
5. Any particular steps to reproduce the issue.
6160
- Keep an eye on the issue for possible questions from the maintainers.
6261

63-
A template for an issue could be the following one:
62+
The following template may serve as a useful guide:
63+
6464
```
6565
## Description
66-
An explanation of the issue
66+
An explanation of the issue
6767
6868
## System info
6969
7070
- Version:
7171
- Arch:
7272
- VMM:
73-
- ...
73+
- ...
7474
7575
## Steps to reproduce
7676
A list of steps that can reproduce the issue.
7777
```
7878

7979
### Requesting new features
8080

81-
We will be very happy to listen from users about new features that they would like to see in `MLSysOps framework`.
81+
We are very happy to hear about features that you would like to see in `MLSysOps framework`.
8282
One way to communicate such a request is using Github issues.
83-
For the time being, we do not use any strict template for requesting new features.
84-
However, we kindly ask you to mark the issue with the enhancement label and provide a description of the new feature.
83+
For the time being, we do not use a strict template for requesting new features, however, we kindly ask you to mark the issue with the enhancement label and provide a description of the feature.
8584

8685
## Submitting a PR
8786

88-
Anyone should feel free to submit a change or an addition to the codebase of `MLSysOps framework`.
87+
Everyone should feel free to submit a change or an addition to the codebase of `MLSysOps framework`.
8988
Currently, we use Github's Pull Requests (PRs) to submit changes to `MLSysOps framework`'s codebase.
9089
Before creating a new PR, please follow the guidelines below:
9190

9291
- Make sure that the changes do not break the building process of `MLSysOps framework`.
93-
- Make sure that all the tests run successfully.
94-
- Make sure that no commit in a PR breaks the building process of `MLSysOps framework`
92+
- Make sure that all tests run successfully.
9593
- Make sure to sign-off your commits.
96-
- Provide meaningful commit messages, describing shortly the changes.
97-
- Provide a meaningful PR message
94+
- Provide meaningful commit messages, briefly describing the changes.
95+
- Provide a meaningful PR message.
9896

9997
As soon as a new PR is created the following workflow will take place:
10098

101-
1. The creator of the PR should invoke the tests by adding the `ok-to-test` label.
102-
2. If the tests pass, request from one or more `MLSysOps framework`'s [maintainers](https://github.com/nubificus/MLSysOps framework/blob/main/MAINTAINERS) to review the PR.
103-
3. The reviewers submit their review.
104-
4. The author of the PR should address all the comments from the reviewers.
105-
5. As soon as a reviewer approves the PR, an action will add the appropriate git trailers in the PR's commits.
106-
6. The reviewer who accepted the changes will merge the new changes.
99+
1. The creator of the PR should invoke the tests by adding the `ok-to-test` label.
100+
2. If the tests pass, request that one or more `MLSysOps framework`'s [maintainers](https://github.com/nubificus/MLSysOps framework/blob/main/MAINTAINERS) review the PR.
101+
3. The reviewers submit their review.
102+
4. The author of the PR should address all the comments from the reviewers.
103+
5. As soon as a reviewer approves the PR, an action will add the appropriate git trailers in the PR's commits.
104+
6. The reviewer who accepted the changes will merge them.
107105

108106
## Labels for the CI
109107

110108
We use github workflows to invoke some tests when a new PR opens for `MLSysOps framework`.
111109
In particular, we perform the following workflows tests:
112110

113-
- Linting of the commit message. Please check the [git commit message style](#git-commit-messages) below for more info.
114-
- Spell check, since `MLSysOps framework` repository contains its documentation too.
111+
- Commit message linting: Please check the [git commit message style](#git-commit-messages) below for more info.
112+
- Spell checking: since the `MLSysOps framework` repository contains its documentation too.
115113
- License check
116-
- Code linting.
114+
- Code linting
117115
- Building artifacts for amd64 and aarch64.
118116
- Unit tests
119117
- End-to-end tests
120118

121-
For a better control over the tests and workflows that run in a PR, we define
122-
three labels which can be used:
119+
For better control over the tests and workflows that run in a PR, we define three PR labels:
123120

124121
- `ok-to-test`: Runs a full CI workflow, meaning all lint tests (commit
125122
message, spellcheck, license), Code linting, building for x86 and aarch64,
126-
unit tests and at last end-to-end tests.
127-
- `skip-build`: Skips the building workflows along with unit and end-to end tests
128-
running all the linting tests. This is useful when
129-
the PR is related to docs and it can help for catching spelling errors etc. In
123+
unit tests, and finally, end-to-end tests.
124+
- `skip-build`: Skips the building workflows along with unit test and end-to end tests, while still running all linters. This is useful when
125+
the PR is related to docs because it can help catch spelling errors, etc. In
130126
addition, if the changes are not related to the codebase, running the
131127
end-to-end tests is not required and saves some time.
132128
- `skip-lint`: Skips the linting phase. This is particularly useful on draft
133129
PRs, when we want to just test the functionality of the code (either a bug
134130
fix, or a new feature) and defer the cleanup/polishing of commits, code, and
135-
docs to when the PR will be ready for review.
131+
docs until the PR will be ready for review.
136132

137133
**Note**: Both `skip-build` and `skip-lint` assume that the `ok-to-test` label
138134
is added.
@@ -141,45 +137,47 @@ is added.
141137

142138
### Git commit messages
143139

144-
Please follow the below guidelines for your commit messages:
140+
Please follow the guidelines below for your commit messages:
145141

146142
- Limit the first line to 72 characters or less.
147-
- Limit all the other lines to 80 characters
143+
- Limit all other lines to 80 characters.
148144
- Follow the [Conventional Commits](https://www.conventionalcommits.org/)
149145
specification and, specifically, format the header as `<type>[optional scope]:
150-
<description>`, where `description` must not end with a fullstop and `type`
146+
<description>`, where `description` must not end with a full stop and `type`
151147
can be one of:
152-
153-
- *feat*: A new feature
154-
- *fix*: A bug fix
155-
- *docs*: Documentation only changes
156-
- *style*: Changes that do not affect the meaning of the code (white-space,
148+
- _feat_: A new feature
149+
- _fix_: A bug fix
150+
- _docs_: Documentation only changes
151+
- _style_: Changes that do not affect the meaning of the code (white-space,
157152
formatting, missing semi-colons, etc)
158-
- *refactor*: A code change that neither fixes a bug nor adds a feature
159-
- *`perf`*: A code change that improves performance
160-
- *test*: Adding missing tests
161-
- *build*: Changes that affect the build system or external dependencies
162-
(example scopes: gulp, broccoli, `npm`)
163-
- *ci*: Changes to our CI configuration files and scripts (example scopes:
153+
- _refactor_: A code change that neither fixes a bug nor adds a feature
154+
- _`perf`_: A code change that improves performance
155+
- _test_: Adding missing tests
156+
- _build_: Changes that affect the build system or external dependencies
157+
(example scopes: `gulp`, `broccoli`, `npm`)
158+
- _ci_: Changes to our CI configuration files and scripts (example scopes:
164159
`Travis`, `Circle`, `BrowserStack`, `SauceLabs`)
165-
- *chore*: Other changes that don't modify src or test files
166-
- *revert*: Reverts a previous commit
167-
- In case the PR is associated with an issue, please refer to it, using the git trailer `Fixes: #Nr_issue`
168-
- Always sign-off your commit message
160+
- _chore_: Other changes that don't modify source code or test files
161+
- _revert_: Reverts a previous commit
162+
163+
- In case the PR is associated with an issue, please refer to it, using the git trailer `Fixes: #<issue number>`, i.e. `Fixes: #30`.
164+
- Always sign-off your commit message.
169165

170-
Since the MLSysOps framework comprises code written in various programming
171-
languages we use the following styles for each:
166+
Since the `MLSysOps framework` comprises code written in various programming
167+
languages, we use the following styles for each:
172168

173169
### Golang code style
174170

175-
We follow `gofmt`'s rules on formatting GO code. Therefore, we ask all
176-
contributors to do the same. Go provides the `gofmt` tool, which can be used
171+
We follow `gofmt`'s formatting rules. Therefore, we ask all
172+
contributors to do the same. Go provides the `gofmt` tool, which can be used
177173
for formatting your code.
178174

179175
### Python
180-
TBC
176+
177+
TBC
181178

182179
### C
180+
183181
TBC
184182

185183
## Contact

0 commit comments

Comments
 (0)