From a57f5e1f2b6065214bafdb9c33f97a752d390da2 Mon Sep 17 00:00:00 2001 From: John Keane Date: Thu, 18 Apr 2019 09:38:49 -0400 Subject: [PATCH 1/5] Update Fault Model Add arguments property --- src/models/Fault.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/models/Fault.js b/src/models/Fault.js index 249f809..583ec77 100644 --- a/src/models/Fault.js +++ b/src/models/Fault.js @@ -41,6 +41,12 @@ export default class Fault { * @member {String} type */ this.type = undefined + + /** + * These are optional arguments returned with fault + * @member {Object} arguments + */ + this.arguments = undefined } /** @@ -62,6 +68,9 @@ export default class Fault { if (data.hasOwnProperty('type')) { obj['type'] = ApiClient.convertToType(data['type'], 'String') } + if (data.hasOwnProperty('arguments')) { + obj['arguments'] = ApiClient.convertToType(data['arguments'], Object) + } } return obj From 1a7ea3ddadeb8a5f04b9c884bc8da621b0be13c9 Mon Sep 17 00:00:00 2001 From: John Keane Date: Mon, 6 May 2019 18:53:53 -0400 Subject: [PATCH 2/5] Added more descriptive data property name --- src/models/Fault.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/models/Fault.js b/src/models/Fault.js index 583ec77..9ed0934 100644 --- a/src/models/Fault.js +++ b/src/models/Fault.js @@ -69,7 +69,7 @@ export default class Fault { obj['type'] = ApiClient.convertToType(data['type'], 'String') } if (data.hasOwnProperty('arguments')) { - obj['arguments'] = ApiClient.convertToType(data['arguments'], Object) + obj['arguments'] = ApiClient.convertToType(data['arguments'], {String: Object}) } } From 678db349228c672c31b82cb71bdeb00400543c17 Mon Sep 17 00:00:00 2001 From: Ben Chypak Date: Tue, 7 May 2019 09:00:22 -0700 Subject: [PATCH 3/5] Update lock file and fix linter error --- package-lock.json | 2 +- src/models/Fault.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 11542fb..cdbc66c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "commercecloud-ocapi-client", - "version": "0.1.6", + "version": "0.1.7", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/src/models/Fault.js b/src/models/Fault.js index 9ed0934..ad15f9e 100644 --- a/src/models/Fault.js +++ b/src/models/Fault.js @@ -46,7 +46,7 @@ export default class Fault { * These are optional arguments returned with fault * @member {Object} arguments */ - this.arguments = undefined + this.arguments = undefined } /** From c35d6294764daa5fd27bc8639f31380545c3d454 Mon Sep 17 00:00:00 2001 From: Ben Chypak Date: Tue, 7 May 2019 09:29:24 -0700 Subject: [PATCH 4/5] Add fault test for store api --- test/api/StoresApi.spec.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/api/StoresApi.spec.js b/test/api/StoresApi.spec.js index d672ecf..87cde7a 100644 --- a/test/api/StoresApi.spec.js +++ b/test/api/StoresApi.spec.js @@ -75,6 +75,14 @@ describe('StoresApi', () => { expect(store.constructor.name).to.be('Store') }) ) + + it('should throw Fault when calling getStoresByID with unknown store id', () => { + instance.getStoresByID('badstoreid') + .catch((fault) => { + expect(fault.constructor.name).to.be('Fault') + console.log('fault: ', fault) + }) + }) }) describe('getStoresByIDs', () => { From 82c4b0710b0243bb43aed312aa692cebdfadaad3 Mon Sep 17 00:00:00 2001 From: Ben Chypak Date: Tue, 7 May 2019 09:35:29 -0700 Subject: [PATCH 5/5] Update CHANGELOG.md --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 73a1343..c54ca77 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +## To be released +- Update `Fault` model to have `arguments` property. [#18](https://github.com/mobify/commercecloud-ocapi-client/pull/18) + ## v0.1.7 (February 5, 2019) - Add relevant properties to `VariationAttributeValue` model and some others. [#15](https://github.com/mobify/commercecloud-ocapi-client/pull/15)