From abd6ecf52d32b5c2900b16813cff872107ce085e Mon Sep 17 00:00:00 2001 From: Ben Chypak Date: Wed, 22 May 2019 15:54:27 -0700 Subject: [PATCH 1/3] Lets not be opinionated on linebreak styles so we work well with windows and unix devlopers --- es6/mobify-es6.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/es6/mobify-es6.yml b/es6/mobify-es6.yml index 0b87e83..205ade2 100644 --- a/es6/mobify-es6.yml +++ b/es6/mobify-es6.yml @@ -148,9 +148,6 @@ rules: jsx-quotes: error key-spacing: error keyword-spacing: error - linebreak-style: - - error - - unix max-depth: - error - max: 5 From c3df5b4dfa9abdc457277bb40bc612c8a42cdff5 Mon Sep 17 00:00:00 2001 From: Ben Chypak Date: Thu, 23 May 2019 11:57:33 -0700 Subject: [PATCH 2/3] Fix good.md and good.expected.md linting. Fixed inconsistent console log. --- docs/test/good.expected.md | 4 ++-- docs/test/good.md | 4 ++-- docs/test/test.sh | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/test/good.expected.md b/docs/test/good.expected.md index 26572a9..c3e687b 100644 --- a/docs/test/good.expected.md +++ b/docs/test/good.expected.md @@ -4,13 +4,13 @@ Used to test style. ## GOOD: One level step down headings. - + ### GOOD: Repeated Content when rule is disabled ### GOOD: Repeated Content when rule is disabled - + ## GOOD: Section with subsections that duplicate diff --git a/docs/test/good.md b/docs/test/good.md index 3b0dc0b..66c761b 100644 --- a/docs/test/good.md +++ b/docs/test/good.md @@ -4,13 +4,13 @@ Used to test style. ## GOOD: One level step down headings. - + ### GOOD: Repeated Content when rule is disabled ### GOOD: Repeated Content when rule is disabled - + ## GOOD: Section with subsections that duplicate diff --git a/docs/test/test.sh b/docs/test/test.sh index 05d994a..e30a7d2 100644 --- a/docs/test/test.sh +++ b/docs/test/test.sh @@ -23,7 +23,7 @@ echo "Testing bad.md ..." diff <("$LINT_MD" "$TEST_DIR/bad.md" --no-color 2>&1) "$TEST_DIR/bad.expected.md" EXIT_BAD=$? -echo "Testing a-bad-filename.expected.md ..." +echo "Testing a-bad-filename.md ..." diff <("$LINT_MD" "$TEST_DIR/a-bad-filename.md" --no-color 2>&1) "$TEST_DIR/a-bad-filename.expected.md" EXIT_BAD_FILENAME=$? From b5c798bf138a2ecb8e4b0015006d623fb92158b3 Mon Sep 17 00:00:00 2001 From: Ben Chypak Date: Thu, 23 May 2019 14:01:04 -0700 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index afa8ae0..55ebac8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,5 @@ ## To Be Released +- Remove `linebreak-style` blocks windows users from linting their code properly [#169](https://github.com/mobify/mobify-code-style/pull/169) - Add in Responsive Best Practices section, updated references to Adaptive [#165](https://github.com/mobify/mobify-code-style/pull/165) ## v2.8.4 (October 31, 2017)