From 465f89daf551c5a5d5358259910eb9bdf1b5346d Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sat, 19 Nov 2022 15:23:28 +0100 Subject: [PATCH] Makefile: coverage: don't run tests twice Initially the tests were run twice, once with "-i" to "pre build" the tests; 8ebe4356ea2f659758a130ddbed623b7f7010868 Commit cb50952a3a15a58bbbb76003994a694d7a658872 removed the "-i" options, as it's no longer needed since go1.10, however it did not remove the (now duplicate) line, so tests were running twice. Signed-off-by: Sebastiaan van Stijn --- direct.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/direct.mk b/direct.mk index 534a431360..dd6b839e58 100644 --- a/direct.mk +++ b/direct.mk @@ -119,7 +119,6 @@ coverage: ## generate coverprofiles from the unit tests @echo "🐳 $@" @( for pkg in $(filter-out ${INTEGRATION_PACKAGE},${PACKAGES}); do \ go test ${RACE} -tags "${DOCKER_BUILDTAGS}" -test.short -coverprofile="$$(go list -f "{{.Dir}}" $$pkg)/coverage.txt" -covermode=atomic $$pkg || exit; \ - go test ${RACE} -tags "${DOCKER_BUILDTAGS}" -test.short -coverprofile="$$(go list -f "{{.Dir}}" $$pkg)/coverage.txt" -covermode=atomic $$pkg || exit; \ done ) .PHONY: coverage-integration