From 04dc39bc669f47e991078d10a128c12c91e1ecbe Mon Sep 17 00:00:00 2001
From: Max Isbey <224885523+maxisbey@users.noreply.github.com>
Date: Tue, 28 Oct 2025 19:20:18 +0000
Subject: [PATCH] fix: Replace fixed sleep with active server readiness check
 in SSE tests

The test_sse_security_wildcard_ports test was flaky due to a race condition
where the test tried to connect before uvicorn was ready to accept connections.

The original code used time.sleep(1) which was:
- Sometimes too short (causing flaky CI failures)
- Always wasteful when server started quickly
- Non-deterministic

This change replaces the arbitrary sleep with wait_for_server() which:
- Actively polls the server port until it accepts connections
- Returns immediately when ready (faster in most cases)
- Has a clear 5-second timeout for true failures
- Eliminates the race condition entirely

The fix makes the tests deterministic and often faster than before.
---
 tests/server/test_sse_security.py | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/tests/server/test_sse_security.py b/tests/server/test_sse_security.py
index bdaec6bdba..5a2210b8e1 100644
--- a/tests/server/test_sse_security.py
+++ b/tests/server/test_sse_security.py
@@ -66,12 +66,32 @@ async def handle_sse(request: Request):
     uvicorn.run(starlette_app, host="127.0.0.1", port=port, log_level="error")
 
 
+def wait_for_server(port: int, timeout: float = 5.0) -> None:
+    """Wait for server to be ready to accept connections.
+
+    Polls the server port until it accepts connections or timeout is reached.
+    This eliminates race conditions without arbitrary sleeps.
+    """
+    start_time = time.time()
+    while time.time() - start_time < timeout:
+        try:
+            with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
+                s.settimeout(0.1)
+                s.connect(("127.0.0.1", port))
+                # Server is ready
+                return
+        except (ConnectionRefusedError, OSError):
+            # Server not ready yet, retry quickly
+            time.sleep(0.01)
+    raise TimeoutError(f"Server on port {port} did not start within {timeout} seconds")
+
+
 def start_server_process(port: int, security_settings: TransportSecuritySettings | None = None):
     """Start server in a separate process."""
     process = multiprocessing.Process(target=run_server_with_settings, args=(port, security_settings))
     process.start()
-    # Give server time to start
-    time.sleep(1)
+    # Wait for server to be ready to accept connections
+    wait_for_server(port)
     return process