Skip to content

Conversation

@lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Dec 8, 2025

I left TabOptions and OpenWorkspaceOptions in the store because that seems to only be used when we use other workspaces code anyway.

We'll probably have to add to this or do more refactoring as a follow-up so we can open a workspace tab from the assistant. But that's a problem for later.

Copilot AI review requested due to automatic review settings December 8, 2025 19:59
@lerouxb lerouxb requested a review from a team as a code owner December 8, 2025 19:59
@lerouxb lerouxb requested a review from Anemy December 8, 2025 19:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR splits workspace-related types from @mongodb-js/compass-workspaces into a new standalone package @mongodb-js/workspace-info. This enables other packages to import workspace types without creating circular dependencies with the main workspaces package.

  • Creates a new @mongodb-js/workspace-info package containing workspace type definitions and schemas
  • Updates all workspace type imports across the codebase to reference the new package
  • Maintains OpenWorkspaceOptions in compass-workspaces while moving core workspace types to workspace-info

Reviewed changes

Copilot reviewed 62 out of 64 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/workspace-info/package.json New package configuration for workspace-info types library
packages/workspace-info/src/workspace-info.ts Adds CollectionTabInfo and DatabaseTabInfo type definitions
packages/workspace-info/src/index.ts Package exports for types and schemas
packages/compass-workspaces/src/stores/workspaces.ts Imports workspace types from new package, moves type definitions
packages/compass-workspaces/src/index.ts Updates exports to reference new package location
packages/databases-collections/src/index.ts Updates WorkspacePlugin import to new package
packages/compass/src/app/components/workspace.tsx Updates type imports to new package
packages/compass-welcome/package.json Adds workspace-info dependency
packages/compass-shell/package.json Adds workspace-info dependency
packages/compass-collection/src/modules/collection-tab.ts Updates CollectionSubtab import to new package

@lerouxb lerouxb force-pushed the add-workspace-info branch from a8602ed to d0b6f6b Compare December 8, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants