From 4357f05e619169e5860cf9045ec06cdc60eb9aab Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Fri, 2 Jun 2017 14:38:33 -0700 Subject: [PATCH] Do not declare a type that is never used Previously, ClassName was declared, but the declared version of it was never used. Instead, the declared version was replaced by LoadableClass. I believe this to be the underlying cause of https://rt.cpan.org/Public/Bug/Display.html?id=119534, which exposed this error as the previously unused sub was being called by undefer_all. --- Changes | 2 ++ lib/MooseX/Types/LoadableClass.pm | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Changes b/Changes index 0cc622f..0288493 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,8 @@ Revision history for MooseX-Types-LoadableClass {{$NEXT}} + - do not create an extra, unused ClassName type + 0.014 2015-08-16 02:03:26Z - update some distribution tooling diff --git a/lib/MooseX/Types/LoadableClass.pm b/lib/MooseX/Types/LoadableClass.pm index efcb110..3bc9358 100644 --- a/lib/MooseX/Types/LoadableClass.pm +++ b/lib/MooseX/Types/LoadableClass.pm @@ -6,7 +6,7 @@ our $VERSION = '0.015'; use strict; use warnings; -use MooseX::Types -declare => [qw/ ClassName LoadableClass LoadableRole /]; +use MooseX::Types -declare => [qw/ LoadableClass LoadableRole /]; use MooseX::Types::Moose qw(Str RoleName), ClassName => { -as => 'MooseClassName' }; use Module::Runtime qw(is_module_name use_package_optimistically); use if MooseX::Types->VERSION >= 0.42, 'namespace::autoclean';