chore: update expected metadata with null published times#866
Merged
fchasen merged 1 commit intomozilla:mainfrom May 10, 2024
Merged
chore: update expected metadata with null published times#866fchasen merged 1 commit intomozilla:mainfrom
fchasen merged 1 commit intomozilla:mainfrom
Conversation
fchasen
approved these changes
May 10, 2024
fchasen
left a comment
fchasen
left a comment
There was a problem hiding this comment.
Thanks so much for adding that to so many tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a separate issue, I ran
node generate-testcase.js allto make debugging a little easier and noticed many testcases hadn't been updated to includepublishedTimewhen it would result in anullvalue.This PR adds those
nullvalues and apparently removes a newline from thevisibility-hiddentest case.