diff --git a/webhook_server_container/libs/github_api.py b/webhook_server_container/libs/github_api.py index 39bcc58c..dd58e8cb 100644 --- a/webhook_server_container/libs/github_api.py +++ b/webhook_server_container/libs/github_api.py @@ -2131,11 +2131,19 @@ def _check_if_pr_approved(self, labels: list[str]) -> str: error += f"Missing approved from approvers: {', '.join(missing_approvers)}\n" if lgtm_count < self.minimum_lgtm: - all_reviewers = self.all_reviewers.copy() - if self.parent_committer in all_reviewers: - all_reviewers.pop(all_reviewers.index(self.parent_committer)) + if lgtm_count == len(self.all_reviewers): + self.logger.debug( + f"{self.log_prefix} minimum_lgtm is {self.minimum_lgtm}, but number of reviewers is {len(self.all_reviewers)}. PR approved." + ) + else: + all_reviewers = self.all_reviewers.copy() + if self.parent_committer in all_reviewers: + all_reviewers.pop(all_reviewers.index(self.parent_committer)) - error += f"Missing lgtm from reviewers. Minimum {self.minimum_lgtm} required. Reviewers: {', '.join(all_reviewers)}.\n" + error += ( + "Missing lgtm from reviewers. " + f"Minimum {self.minimum_lgtm} required. Reviewers: {', '.join(all_reviewers)}.\n" + ) return error