diff --git a/lib/httpclient.rb b/lib/httpclient.rb index 40d7ce06..33859e5a 100644 --- a/lib/httpclient.rb +++ b/lib/httpclient.rb @@ -420,7 +420,7 @@ def initialize(*args, &block) load_environment self.proxy = proxy if proxy keep_webmock_compat - instance_eval &block if block + instance_eval(&block) if block end # webmock 1.6.2 depends on HTTP::Message#body.content to work. @@ -1081,7 +1081,7 @@ def success_content(res) def protect_keep_alive_disconnected begin yield - rescue KeepAliveDisconnected => e + rescue KeepAliveDisconnected # Force to create new connection Thread.current[:HTTPClient_AcquireNewConnection] = true begin diff --git a/lib/httpclient/auth.rb b/lib/httpclient/auth.rb index 1c7a2fc4..f52a4432 100644 --- a/lib/httpclient/auth.rb +++ b/lib/httpclient/auth.rb @@ -535,7 +535,7 @@ def set? def get(req) target_uri = req.header.request_uri synchronize { - domain_uri, param = @challenge.find { |uri, v| + _domain_uri, param = @challenge.find { |uri, v| Util.uri_part_of(target_uri, uri) } return nil unless param diff --git a/test/test_auth.rb b/test/test_auth.rb index 156d2f1b..41a5edf5 100644 --- a/test/test_auth.rb +++ b/test/test_auth.rb @@ -124,6 +124,7 @@ def self.decode_utf16le(*arg) end # Make it work if @value == nil class SecurityBuffer < FieldSet + remove_method(:data_size) if method_defined?(:data_size) def data_size @active && @value ? @value.size : 0 end @@ -230,7 +231,7 @@ def test_BASIC_auth_multi_thread c.www_auth.basic_auth.instance_eval { @scheme = "BASIC" } c.set_auth("http://localhost:#{serverport}/", 'admin', 'admin') - threads = 100.times.map { |idx| + 100.times.map { |idx| Thread.new(idx) { |idx2| Thread.abort_on_exception = true Thread.pass @@ -251,7 +252,7 @@ def test_basic_auth_reuses_credentials c.test_loopback_http_response << "HTTP/1.0 200 OK\nContent-Length: 2\n\nOK" c.debug_dev = str = '' c.get_content("http://localhost:#{serverport}/basic_auth/sub/dir/") - assert_match /Authorization: Basic YWRtaW46YWRtaW4=/, str + assert_match(/Authorization: Basic YWRtaW46YWRtaW4=/, str) end def test_digest_auth @@ -267,7 +268,7 @@ def test_digest_auth_reuses_credentials c.test_loopback_http_response << "HTTP/1.0 200 OK\nContent-Length: 2\n\nOK" c.debug_dev = str = '' c.get_content("http://localhost:#{serverport}/digest_auth/sub/dir/") - assert_match /Authorization: Digest/, str + assert_match(/Authorization: Digest/, str) end def test_digest_auth_with_block diff --git a/test/test_cookie.rb b/test/test_cookie.rb index 89c26e76..57be1e07 100644 --- a/test/test_cookie.rb +++ b/test/test_cookie.rb @@ -290,8 +290,8 @@ def test_keep_escaped def test_load_cookies_escaped uri = urify('http://example.org/') f = Tempfile.new('test_cookie') - File.open(f.path, 'w') do |f| - f.write < myio }) + _res = @client.post(serverurl + 'servlet', { :file => myio }) assert_match(/\r\n4\r\n/, str.string, 'should send "4" not "45"') end @@ -972,7 +972,7 @@ def size end end @client.debug_dev = str = StringIO.new - res = @client.post(serverurl + 'servlet', { :file1 => myio1, :file2 => myio2 }) + _res = @client.post(serverurl + 'servlet', { :file1 => myio1, :file2 => myio2 }) assert_match(/\r\n45\r\n/, str.string) end @@ -1243,7 +1243,7 @@ def test_extra_headers def test_http_custom_date_header @client.debug_dev = (str = "") - res = @client.get(serverurl + 'hello', :header => {'Date' => 'foo'}) + _res = @client.get(serverurl + 'hello', :header => {'Date' => 'foo'}) lines = str.split(/(?:\r?\n)+/) assert_equal('Date: foo', lines[4]) end diff --git a/test/test_webagent-cookie.rb b/test/test_webagent-cookie.rb index ea02ff9c..29a415b4 100644 --- a/test/test_webagent-cookie.rb +++ b/test/test_webagent-cookie.rb @@ -440,8 +440,8 @@ def test_escaped def test_load_cookies_escaped uri = urify('http://example.org/') f = Tempfile.new('test_cookie') - File.open(f.path, 'w') do |f| - f.write <