From 5700b4df8214d43637b2e374a2aba0ea4067880a Mon Sep 17 00:00:00 2001 From: Nicolas Barascud <10333715+nbara@users.noreply.github.com> Date: Tue, 28 Nov 2023 10:52:36 +0100 Subject: [PATCH 1/2] [HOTFIX] find_outlier_trials() bug --- meegkit/utils/denoise.py | 2 +- tests/test_utils.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meegkit/utils/denoise.py b/meegkit/utils/denoise.py index ef253468..aa7b750f 100644 --- a/meegkit/utils/denoise.py +++ b/meegkit/utils/denoise.py @@ -223,7 +223,7 @@ def find_outlier_trials(X, thresh=None, show=True): plt.show() thresh = thresh[1:] - if thresh: + if thresh.any(): bads, _ = find_outlier_trials(X[:, idx], thresh, show) idx = np.setdiff1d(idx, idx[bads]) diff --git a/tests/test_utils.py b/tests/test_utils.py index 8370986e..baf9f4ad 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -238,7 +238,7 @@ def test_outliers(show=False): idx, _ = find_outlier_trials(x, 2, show=show) np.testing.assert_array_equal(idx, np.arange(5)) - idx, _ = find_outlier_trials(x, [2, 2], show=True) + idx, _ = find_outlier_trials(x, [5, 2, 2], show=True) np.testing.assert_array_equal(idx, np.arange(5)) idx = find_outlier_samples(x, 5) From 2c567317c8227837658d6993c698a1cc944c5c84 Mon Sep 17 00:00:00 2001 From: Nicolas Barascud <10333715+nbara@users.noreply.github.com> Date: Tue, 28 Nov 2023 11:13:35 +0100 Subject: [PATCH 2/2] version --- citation.cff | 4 ++-- meegkit/__init__.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/citation.cff b/citation.cff index 490d0cfb..e103a964 100644 --- a/citation.cff +++ b/citation.cff @@ -5,7 +5,7 @@ authors: given-names: "Nicolas" orcid: "https://orcid.org/0000-0003-1495-561X" title: "MEEGkit" -version: 0.1.5 +version: 0.1.6 doi: 10.5281/zenodo.10210992 -date-released: 2023-11-27 +date-released: 2023-11-28 url: "https://github.com/nbara/python-meegkit" diff --git a/meegkit/__init__.py b/meegkit/__init__.py index 3b337ab0..c7a11d48 100644 --- a/meegkit/__init__.py +++ b/meegkit/__init__.py @@ -1,5 +1,5 @@ """M/EEG denoising utilities in python.""" -__version__ = "0.1.5" +__version__ = "0.1.6" from . import asr, cca, detrend, dss, lof, ress, sns, star, trca, tspca, utils