-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closes #20564: Many-to-many pass-through port mappings #20851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ing front/rear ports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only changes made in this file are to update the test data to use PortMappings. None of the test methods themselves have been significantly modified.
|
Aside from the incomplete items noted in the TODO list above, I believe this is ready for review. |
arthanson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - the main item is fixing the confusing "rear ports" reference, should be "front ports" on the rear ports detail page. Couple other suggested UI tweaks.
Agreed, but this improvement would be out of scope for #20564. Do you want to open a separate FR for it? |



Closes: #20564
Note: Any changes made for FrontPort or RearPort are also made for their corresponding template models, FrontPortTemplate and RearPortTemplate, unless otherwise notes.
PortMappingmodel to map port & position pairs between FrontPorts and RearPortsmappingsrelation on both FrontPort & RearPortpositionsIntegerField on FrontPort to match the existingpositionsfield on RearPortrear_portForeignKey andrear_port_positionIntegerField from FrontPortfront_portson RearPortSerializerrear_portson FrontPortSerializercreate_port_mappings()function for this purposerear_portandrear_port_positioncolumns from FrontPortTablemappingscolumn to both FrontPortTable and RearPortTablefront_port_idfilter for RearPort and update FrontPort'srear_port_idfilterpositionsfilter for FrontPort and FrontPortTemplaterear_portfield on FrontPortType withmappingsmappingsto RearPortTypeTODO
Cable.from_origin()