From 62dd9d90c939c06f0d58ad0ededf4c230c6f3288 Mon Sep 17 00:00:00 2001 From: Jim Klimov Date: Sun, 8 Nov 2020 03:25:27 +0100 Subject: [PATCH] drivers/mge-xml.c: avoid implicit switch fall-through (comment whether that wondering is the right thing to do though) --- drivers/mge-xml.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mge-xml.c b/drivers/mge-xml.c index 5e15c4caa9..ec993848c7 100644 --- a/drivers/mge-xml.c +++ b/drivers/mge-xml.c @@ -1361,8 +1361,12 @@ static int mge_xml_startelm_cb(void *userdata, int parent, const char *nspace, c state = XC_GENERAL; break; } + /* FIXME? Is the fall-through to handling "GENERAL" intended? + * was so in legacy code before the goto below... */ + goto fallthrough_case_general; case XC_GENERAL: + fallthrough_case_general: if (!strcasecmp(name, "STARTUP")) { /* config="CENTRALIZED" */ state = XC_STARTUP;