From a58452d43b41409128dd9424ea1da6059f1e44f2 Mon Sep 17 00:00:00 2001
From: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
Date: Mon, 15 Apr 2024 13:28:42 +0300
Subject: [PATCH 1/2] fix of possible "undefined variable" error

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
---
 lib/DeployActions/DockerActions.php | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/DeployActions/DockerActions.php b/lib/DeployActions/DockerActions.php
index 01f5652c..4418cb69 100644
--- a/lib/DeployActions/DockerActions.php
+++ b/lib/DeployActions/DockerActions.php
@@ -355,15 +355,14 @@ public function buildDeployParams(DaemonConfig $daemonConfig, array $appInfo): a
 		$externalApp = $appInfo['external-app'];
 		$deployConfig = $daemonConfig->getDeployConfig();
 
+		$deviceRequests = [];
+		$devices = [];
 		if (isset($deployConfig['computeDevice'])) {
 			if ($deployConfig['computeDevice']['id'] === 'cuda') {
 				$deviceRequests = $this->buildDefaultGPUDeviceRequests();
 			} elseif ($deployConfig['computeDevice']['id'] === 'rocm') {
 				$devices = $this->buildDevicesParams(['/dev/kfd', '/dev/dri']);
 			}
-		} else {
-			$deviceRequests = [];
-			$devices = [];
 		}
 		$storage = $this->buildDefaultExAppVolume($appId)[0]['Target'];
 

From 360e63eebed577bcacb1fe458053c77e09ea4e5b Mon Sep 17 00:00:00 2001
From: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
Date: Mon, 15 Apr 2024 13:38:43 +0300
Subject: [PATCH 2/2] calmed the linter for `info.xml`

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
---
 appinfo/info.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/appinfo/info.xml b/appinfo/info.xml
index 35a5a996..d66b4d7c 100644
--- a/appinfo/info.xml
+++ b/appinfo/info.xml
@@ -54,9 +54,9 @@ to join us in shaping a more versatile, stable, and secure app landscape.
 	<category>integration</category>
 	<category>tools</category>
 	<website>https://github.com/cloud-py-api/app_api</website>
+	<discussion>https://github.com/cloud-py-api/app_api/discussions</discussion>
 	<bugs>https://github.com/cloud-py-api/app_api/issues</bugs>
 	<repository type="git">https://github.com/cloud-py-api/app_api.git</repository>
-	<discussion>https://github.com/cloud-py-api/app_api/discussions</discussion>
 	<screenshot>https://raw.githubusercontent.com/cloud-py-api/app_api/main/screenshots/app_api_1.png</screenshot>
 	<screenshot>https://raw.githubusercontent.com/cloud-py-api/app_api/main/screenshots/app_api_2.png</screenshot>
 	<screenshot>https://raw.githubusercontent.com/cloud-py-api/app_api/main/screenshots/app_api_3.png</screenshot>