From 6009c105796948004793c6594e9e1ef4cfdd490a Mon Sep 17 00:00:00 2001
From: Ishant <ishantgupta777@gmail.com>
Date: Sat, 18 Apr 2020 05:40:54 +0530
Subject: [PATCH 1/3] fixed tooltip bug and closes #1679

Signed-off-by: Ishant <ishantgupta777@gmail.com>
---
 src/components/Controls.vue                   | 22 +++++++++----------
 src/components/boards/BoardItem.vue           |  3 ++-
 .../navigation/AppNavigationBoard.vue         |  8 +++++--
 3 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/src/components/Controls.vue b/src/components/Controls.vue
index f238b4d72..c6cdb5ba1 100644
--- a/src/components/Controls.vue
+++ b/src/components/Controls.vue
@@ -31,9 +31,11 @@
 			</p>
 		</div>
 		<div v-if="board" class="board-actions">
-			<div v-if="canManage && !showArchived" id="stack-add" v-click-outside="hideAddStack">
-				<Actions v-if="!isAddStackVisible">
-					<ActionButton icon="icon-add" :title="t('deck', 'Add new list')" @click.stop="showAddStack" />
+			<div v-if="canManage && !showArchived"
+				id="stack-add"
+				v-click-outside="hideAddStack">
+				<Actions v-if="!isAddStackVisible" :title="t('deck', 'Add new list')">
+					<ActionButton icon="icon-add" @click.stop="showAddStack" />
 				</Actions>
 				<form v-else @submit.prevent="addNewStack()">
 					<label for="new-stack-input-main" class="hidden-visually">{{ t('deck', 'Add new list') }}</label>
@@ -52,8 +54,8 @@
 			</div>
 			<div class="board-action-buttons">
 				<Popover>
-					<Actions slot="trigger" :style="filterOpacity">
-						<ActionButton icon="icon-filter" :title="t('deck', 'Apply filter')" />
+					<Actions slot="trigger" :style="filterOpacity" :title="t('deck', 'Apply filter')">
+						<ActionButton icon="icon-filter" />
 					</Actions>
 
 					<template>
@@ -148,28 +150,24 @@
 					</template>
 				</Popover>
 
-				<Actions :style="archivedOpacity">
+				<Actions :style="archivedOpacity" :title="t('deck', 'Show archived cards')">
 					<ActionButton v-if="showArchived"
 						icon="icon-archive"
-						:title="t('deck', 'Show archived cards')"
 						@click="toggleShowArchived" />
 					<ActionButton v-else
 						icon="icon-archive"
-						:title="t('deck', 'Hide archived cards')"
 						@click="toggleShowArchived" />
 				</Actions>
-				<Actions>
+				<Actions :title="t('deck', 'Toggle compact mode')">
 					<ActionButton v-if="compactMode"
 						icon="icon-toggle-compact-collapsed"
-						:title="t('deck', 'Toggle compact mode')"
 						@click="toggleCompactMode" />
 					<ActionButton v-else
 						icon="icon-toggle-compact-expanded"
-						:title="t('deck', 'Toggle compact mode')"
 						@click="toggleCompactMode" />
 				</Actions>
 				<!-- FIXME: ActionRouter currently doesn't work as an inline action -->
-				<Actions>
+				<Actions :title="t('deck', 'Details')">
 					<ActionButton icon="icon-menu-sidebar" @click="toggleDetailsView" />
 				</Actions>
 			</div>
diff --git a/src/components/boards/BoardItem.vue b/src/components/boards/BoardItem.vue
index 2ebbeefad..73bf84045 100644
--- a/src/components/boards/BoardItem.vue
+++ b/src/components/boards/BoardItem.vue
@@ -33,10 +33,11 @@
 			{{ board.title }}
 		</div>
 		<div class="board-list-avatars-cell">
-			<Avatar :user="board.owner.uid" class="board-list-avatar" />
+			<Avatar :user="board.owner.uid" :title="board.owner.displayname" class="board-list-avatar" />
 			<Avatar v-for="user in limitedAcl"
 				:key="user.id"
 				:user="user.participant.uid"
+				:title="user.participant.displayname"
 				class="board-list-avatar" />
 			<div v-if="board.acl.length > 5" v-tooltip="otherAcl" class="avatardiv popovermenu-wrapper board-list-avatar icon-more" />
 		</div>
diff --git a/src/components/navigation/AppNavigationBoard.vue b/src/components/navigation/AppNavigationBoard.vue
index 8f9ab828c..95f265bd5 100644
--- a/src/components/navigation/AppNavigationBoard.vue
+++ b/src/components/navigation/AppNavigationBoard.vue
@@ -36,11 +36,15 @@
 					<button v-if="board.acl.length === 0"
 						class="icon-shared"
 						style="opacity: 0.3"
+						:title="'Share'"
+						@click="showSidebar" />
+					<button v-else
+						class="icon-shared"
+						:title="'Share'"
 						@click="showSidebar" />
-					<button v-else class="icon-shared" @click="showSidebar" />
 				</li>
 				<li class="app-navigation-entry-utils-menu-button">
-					<button v-click-outside="hideMenu" @click="showMenu" />
+					<button v-click-outside="hideMenu" :title="'Options'" @click="showMenu" />
 				</li>
 			</ul>
 		</div>

From ec5a8e9ebe37448ddbc44fbbaf9884a57e6935bc Mon Sep 17 00:00:00 2001
From: Ishant <ishantgupta777@gmail.com>
Date: Sat, 18 Apr 2020 18:33:32 +0530
Subject: [PATCH 2/3] translations added

Signed-off-by: Ishant <ishantgupta777@gmail.com>
---
 src/components/boards/BoardItem.vue              | 2 +-
 src/components/navigation/AppNavigationBoard.vue | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/components/boards/BoardItem.vue b/src/components/boards/BoardItem.vue
index 73bf84045..288e6d3a2 100644
--- a/src/components/boards/BoardItem.vue
+++ b/src/components/boards/BoardItem.vue
@@ -32,7 +32,7 @@
 		<div class="board-list-title-cell">
 			{{ board.title }}
 		</div>
-		<div class="board-list-avatars-cell">
+		<div class="board-list-avatars-cell" :title="''">
 			<Avatar :user="board.owner.uid" :title="board.owner.displayname" class="board-list-avatar" />
 			<Avatar v-for="user in limitedAcl"
 				:key="user.id"
diff --git a/src/components/navigation/AppNavigationBoard.vue b/src/components/navigation/AppNavigationBoard.vue
index 95f265bd5..68fb2e98f 100644
--- a/src/components/navigation/AppNavigationBoard.vue
+++ b/src/components/navigation/AppNavigationBoard.vue
@@ -36,15 +36,15 @@
 					<button v-if="board.acl.length === 0"
 						class="icon-shared"
 						style="opacity: 0.3"
-						:title="'Share'"
+						:title="t('deck', 'Share')"
 						@click="showSidebar" />
 					<button v-else
 						class="icon-shared"
-						:title="'Share'"
+						:title="t('deck', 'Share')"
 						@click="showSidebar" />
 				</li>
 				<li class="app-navigation-entry-utils-menu-button">
-					<button v-click-outside="hideMenu" :title="'Options'" @click="showMenu" />
+					<button v-click-outside="hideMenu" :title="t('deck', 'Options')" @click="showMenu" />
 				</li>
 			</ul>
 		</div>

From 7234e3a4bb9b1503fdbe3a19bbe5edcb4b109e30 Mon Sep 17 00:00:00 2001
From: Ishant <ishantgupta777@gmail.com>
Date: Sun, 19 Apr 2020 18:24:24 +0530
Subject: [PATCH 3/3] title changes with tooltip

Signed-off-by: Ishant <ishantgupta777@gmail.com>
---
 src/components/boards/BoardItem.vue              | 6 +++---
 src/components/navigation/AppNavigationBoard.vue | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/components/boards/BoardItem.vue b/src/components/boards/BoardItem.vue
index 288e6d3a2..47664c0aa 100644
--- a/src/components/boards/BoardItem.vue
+++ b/src/components/boards/BoardItem.vue
@@ -32,12 +32,12 @@
 		<div class="board-list-title-cell">
 			{{ board.title }}
 		</div>
-		<div class="board-list-avatars-cell" :title="''">
-			<Avatar :user="board.owner.uid" :title="board.owner.displayname" class="board-list-avatar" />
+		<div class="board-list-avatars-cell" title="">
+			<Avatar :user="board.owner.uid" :display-name="board.owner.displayname" class="board-list-avatar" />
 			<Avatar v-for="user in limitedAcl"
 				:key="user.id"
 				:user="user.participant.uid"
-				:title="user.participant.displayname"
+				:display-name="user.participant.displayname"
 				class="board-list-avatar" />
 			<div v-if="board.acl.length > 5" v-tooltip="otherAcl" class="avatardiv popovermenu-wrapper board-list-avatar icon-more" />
 		</div>
diff --git a/src/components/navigation/AppNavigationBoard.vue b/src/components/navigation/AppNavigationBoard.vue
index 68fb2e98f..e58c79060 100644
--- a/src/components/navigation/AppNavigationBoard.vue
+++ b/src/components/navigation/AppNavigationBoard.vue
@@ -34,17 +34,17 @@
 			<ul>
 				<li class="app-navigation-entry-utils-menu-button">
 					<button v-if="board.acl.length === 0"
+						v-tooltip="t('deck', 'Share')"
 						class="icon-shared"
 						style="opacity: 0.3"
-						:title="t('deck', 'Share')"
 						@click="showSidebar" />
 					<button v-else
+						v-tooltip="t('deck', 'Share')"
 						class="icon-shared"
-						:title="t('deck', 'Share')"
 						@click="showSidebar" />
 				</li>
 				<li class="app-navigation-entry-utils-menu-button">
-					<button v-click-outside="hideMenu" :title="t('deck', 'Options')" @click="showMenu" />
+					<button v-click-outside="hideMenu" v-tooltip="t('deck', 'Options')" @click="showMenu" />
 				</li>
 			</ul>
 		</div>