From 9353e4852c50439e45dd4c444b60b39f96d2c90b Mon Sep 17 00:00:00 2001
From: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Date: Tue, 21 Aug 2018 14:35:03 -0400
Subject: [PATCH 1/4] Added empty message to board list when there are no
 boards present.

Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
---
 css/style.scss               | 5 +++++
 templates/part.boardlist.php | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/css/style.scss b/css/style.scss
index 12504fe91..29798eac5 100644
--- a/css/style.scss
+++ b/css/style.scss
@@ -34,6 +34,11 @@ $color-darkgrey: nc-darken($color-main-background, 32%);
 /**
  * General styles
  */
+
+.center-text {
+	text-align: center;
+}
+
 button,
 .button,
 .app-deck .icon {
diff --git a/templates/part.boardlist.php b/templates/part.boardlist.php
index f7043b51f..f4e6aa19c 100644
--- a/templates/part.boardlist.php
+++ b/templates/part.boardlist.php
@@ -24,7 +24,12 @@
 		</tr>
 		</thead>
 		<tbody>
-		<tr data-ng-repeat="b in boardservice.sorted track by b.id" ng-class="{deleted: b.deletedAt > 0}">
+		<tr ng-if="boardservice.sorted.length == 0">
+			<td class="center-text" colspan="4">
+				<?php p($l->t('There are no boards in this category to display')); ?>
+			</td>
+		</tr>
+		<tr ng-if="boardservice.sorted.length > 0" data-ng-repeat="b in boardservice.sorted track by b.id" ng-class="{deleted: b.deletedAt > 0}">
 			<td ng-click="gotoBoard(b)">
 				<div class="board-bullet" ng-style="{'background-color':'#'+b.color}"> </div>
 			</td>

From 001609982d8f3dbd3d4158bb254b9b4d8483f7e7 Mon Sep 17 00:00:00 2001
From: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Date: Tue, 21 Aug 2018 17:11:47 -0400
Subject: [PATCH 2/4] adjusting solution based on standards shown to me by
 jancborchardt

Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
---
 js/controller/ListController.js |  2 +-
 templates/part.boardlist.php    | 19 +++++++++++--------
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/js/controller/ListController.js b/js/controller/ListController.js
index f3c0baefd..6cd1472fd 100644
--- a/js/controller/ListController.js
+++ b/js/controller/ListController.js
@@ -56,7 +56,7 @@ var ListController = function ($scope, $location, $filter, BoardService, $elemen
 	$scope.boardservice = BoardService;
 	$scope.updatingBoard = null;
 
-	var filterData = function () {
+	var filterData = function () {		
 		if($element.attr('id') === 'app-navigation') {
 			$scope.boardservice.sidebar = $scope.boardservice.getData();
 			$scope.boardservice.sidebar = $filter('orderBy')($scope.boardservice.sidebar, 'title');
diff --git a/templates/part.boardlist.php b/templates/part.boardlist.php
index f4e6aa19c..674eb71d5 100644
--- a/templates/part.boardlist.php
+++ b/templates/part.boardlist.php
@@ -13,7 +13,15 @@
 		</div>
 	</div>
 </div>
-<div id="boardlist">
+<div id="emptycontent" ng-if="boardservice.sorted.length == 0 && status.filter == 'archived'">
+	<div class="icon-archive"></div>
+	<h2>No archived boards to display</h2>
+</div>
+<div id="emptycontent" ng-if="boardservice.sorted.length == 0 && status.filter == 'shared'">
+	<div class="icon-share"></div>
+	<h2>No shared boards to display</h2>
+</div>
+<div id="boardlist" ng-if="boardservice.sorted.length > 0 || !status.filter">
 	<table width="100%">
 		<thead>
 		<tr>
@@ -23,13 +31,8 @@
 			<td></td>
 		</tr>
 		</thead>
-		<tbody>
-		<tr ng-if="boardservice.sorted.length == 0">
-			<td class="center-text" colspan="4">
-				<?php p($l->t('There are no boards in this category to display')); ?>
-			</td>
-		</tr>
-		<tr ng-if="boardservice.sorted.length > 0" data-ng-repeat="b in boardservice.sorted track by b.id" ng-class="{deleted: b.deletedAt > 0}">
+		<tbody>		
+		<tr data-ng-repeat="b in boardservice.sorted track by b.id" ng-class="{deleted: b.deletedAt > 0}">
 			<td ng-click="gotoBoard(b)">
 				<div class="board-bullet" ng-style="{'background-color':'#'+b.color}"> </div>
 			</td>

From 6fb4525754a206bdd2d113c15c64212d96908c7a Mon Sep 17 00:00:00 2001
From: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Date: Tue, 21 Aug 2018 17:25:09 -0400
Subject: [PATCH 3/4] sending strings through translation code.

Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
---
 templates/part.boardlist.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/templates/part.boardlist.php b/templates/part.boardlist.php
index 674eb71d5..79a3b750a 100644
--- a/templates/part.boardlist.php
+++ b/templates/part.boardlist.php
@@ -15,11 +15,11 @@
 </div>
 <div id="emptycontent" ng-if="boardservice.sorted.length == 0 && status.filter == 'archived'">
 	<div class="icon-archive"></div>
-	<h2>No archived boards to display</h2>
+	<h2><?php p($l->t('No archived boards to display')); ?></h2>
 </div>
 <div id="emptycontent" ng-if="boardservice.sorted.length == 0 && status.filter == 'shared'">
 	<div class="icon-share"></div>
-	<h2>No shared boards to display</h2>
+	<h2> <?php p($l->t('No shared boards to display')); ?> </h2>
 </div>
 <div id="boardlist" ng-if="boardservice.sorted.length > 0 || !status.filter">
 	<table width="100%">

From fd7dd9c3b4de38048f11b881513a5f69693de848 Mon Sep 17 00:00:00 2001
From: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Date: Thu, 23 Aug 2018 07:10:17 -0400
Subject: [PATCH 4/4] cleaning up whitespace / unused css style.

Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
---
 css/style.scss                  | 4 ----
 js/controller/ListController.js | 2 +-
 templates/part.boardlist.php    | 2 +-
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/css/style.scss b/css/style.scss
index 29798eac5..a7f6e627a 100644
--- a/css/style.scss
+++ b/css/style.scss
@@ -35,10 +35,6 @@ $color-darkgrey: nc-darken($color-main-background, 32%);
  * General styles
  */
 
-.center-text {
-	text-align: center;
-}
-
 button,
 .button,
 .app-deck .icon {
diff --git a/js/controller/ListController.js b/js/controller/ListController.js
index 6cd1472fd..f3c0baefd 100644
--- a/js/controller/ListController.js
+++ b/js/controller/ListController.js
@@ -56,7 +56,7 @@ var ListController = function ($scope, $location, $filter, BoardService, $elemen
 	$scope.boardservice = BoardService;
 	$scope.updatingBoard = null;
 
-	var filterData = function () {		
+	var filterData = function () {
 		if($element.attr('id') === 'app-navigation') {
 			$scope.boardservice.sidebar = $scope.boardservice.getData();
 			$scope.boardservice.sidebar = $filter('orderBy')($scope.boardservice.sidebar, 'title');
diff --git a/templates/part.boardlist.php b/templates/part.boardlist.php
index 79a3b750a..a7901e2d5 100644
--- a/templates/part.boardlist.php
+++ b/templates/part.boardlist.php
@@ -31,7 +31,7 @@
 			<td></td>
 		</tr>
 		</thead>
-		<tbody>		
+		<tbody>
 		<tr data-ng-repeat="b in boardservice.sorted track by b.id" ng-class="{deleted: b.deletedAt > 0}">
 			<td ng-click="gotoBoard(b)">
 				<div class="board-bullet" ng-style="{'background-color':'#'+b.color}"> </div>