From 3d9cd00c7b0c5899db24e29dc088b9d885338939 Mon Sep 17 00:00:00 2001 From: Sander Ruitenbeek Date: Mon, 17 Feb 2020 08:42:22 +0000 Subject: [PATCH 1/2] Updated test to check for already enabled apps Signed-off-by: Sander Ruitenbeek --- tests/Core/Command/Apps/AppsEnableTest.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Core/Command/Apps/AppsEnableTest.php b/tests/Core/Command/Apps/AppsEnableTest.php index a8aa4c434f0b7..b5d781aa125c9 100644 --- a/tests/Core/Command/Apps/AppsEnableTest.php +++ b/tests/Core/Command/Apps/AppsEnableTest.php @@ -75,6 +75,7 @@ public function dataCommandInput(): array { $data = [ [['admin_audit'], null, 0, 'admin_audit enabled'], [['comments'], null, 0, 'comments enabled'], + [['comments', 'comments'], null, 0, "comments enabled\ncomments already enabled"], [['invalid_app'], null, 1, 'Could not download app invalid_app'], [['admin_audit', 'comments'], null, 0, "admin_audit enabled\ncomments enabled"], From 6b62bef928cbe392f19e2bbaabff5b17d133e6a9 Mon Sep 17 00:00:00 2001 From: Sander Ruitenbeek Date: Mon, 17 Feb 2020 08:43:46 +0000 Subject: [PATCH 2/2] Display notice for already enabled apps Signed-off-by: Sander Ruitenbeek Signed-off-by: Sander Ruitenbeek --- core/Command/App/Enable.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/Command/App/Enable.php b/core/Command/App/Enable.php index c4e2363def560..d82a71d9eb4bb 100644 --- a/core/Command/App/Enable.php +++ b/core/Command/App/Enable.php @@ -105,6 +105,10 @@ private function enableApp(string $appId, array $groupIds, bool $forceEnable, Ou return $group->getDisplayName(); }, $groupIds); + if ($this->appManager->isInstalled($appId) && $groupIds === []) { + $output->writeln($appId . ' already enabled'); + return; + } try { /** @var Installer $installer */