diff --git a/apps/user_ldap/lib/Group_LDAP.php b/apps/user_ldap/lib/Group_LDAP.php index 199865e762398..6bf1bd31ba04d 100644 --- a/apps/user_ldap/lib/Group_LDAP.php +++ b/apps/user_ldap/lib/Group_LDAP.php @@ -877,8 +877,8 @@ public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0) { ]) ]); $ldap_users = $this->access->fetchListOfUsers($filter, $attrs, 1); - if (count($ldap_users) < 1) { - continue; + if (empty($ldap_users)) { + break; } $groupUsers[] = $this->access->dn2username($ldap_users[0]['dn'][0]); break; @@ -886,13 +886,13 @@ public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0) { //we got DNs, check if we need to filter by search or we can give back all of them $uid = $this->access->dn2username($member); if (!$uid) { - continue; + break; } $cacheKey = 'userExistsOnLDAP' . $uid; $userExists = $this->access->connection->getFromCache($cacheKey); if ($userExists === false) { - continue; + break; } if ($userExists === null || $search !== '') { if (!$this->access->readAttribute($member, @@ -904,7 +904,7 @@ public function usersInGroup($gid, $search = '', $limit = -1, $offset = 0) { if ($search === '') { $this->access->connection->writeToCache($cacheKey, false); } - continue; + break; } $this->access->connection->writeToCache($cacheKey, true); }