From 0c1ccde7d20eaac420f98ebecbac0b53511cc2f0 Mon Sep 17 00:00:00 2001 From: acsfer Date: Thu, 9 Sep 2021 12:10:09 +0200 Subject: [PATCH 1/3] Get `filesize()` if `file_exists()` Should make sense. --- lib/private/Files/Storage/Local.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Files/Storage/Local.php b/lib/private/Files/Storage/Local.php index 4df16b206a534..06e27493adff2 100644 --- a/lib/private/Files/Storage/Local.php +++ b/lib/private/Files/Storage/Local.php @@ -216,7 +216,7 @@ public function filetype($path) { } public function filesize($path) { - if ($this->is_dir($path)) { + if ($this->is_dir($path) || !$this->file_exists($path)) { return 0; } $fullPath = $this->getSourcePath($path); From aeb0ad8cea6369bc8a296a582d2f31478973afe9 Mon Sep 17 00:00:00 2001 From: acsfer Date: Mon, 4 Oct 2021 17:20:17 +0200 Subject: [PATCH 2/3] Replace `file_exists()` method by `is_file()` --- lib/private/Files/Storage/Local.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Files/Storage/Local.php b/lib/private/Files/Storage/Local.php index 06e27493adff2..8c4ba2bbd2fdc 100644 --- a/lib/private/Files/Storage/Local.php +++ b/lib/private/Files/Storage/Local.php @@ -216,7 +216,7 @@ public function filetype($path) { } public function filesize($path) { - if ($this->is_dir($path) || !$this->file_exists($path)) { + if ($this->is_dir($path) || !$this->is_file($path)) { return 0; } $fullPath = $this->getSourcePath($path); From f57bbaf14649f2bf9a2adb84adb312b2e2d029b6 Mon Sep 17 00:00:00 2001 From: acsfer Date: Mon, 4 Oct 2021 17:21:37 +0200 Subject: [PATCH 3/3] Simplify :) --- lib/private/Files/Storage/Local.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Files/Storage/Local.php b/lib/private/Files/Storage/Local.php index 8c4ba2bbd2fdc..0032ca464468e 100644 --- a/lib/private/Files/Storage/Local.php +++ b/lib/private/Files/Storage/Local.php @@ -216,7 +216,7 @@ public function filetype($path) { } public function filesize($path) { - if ($this->is_dir($path) || !$this->is_file($path)) { + if (!$this->is_file($path)) { return 0; } $fullPath = $this->getSourcePath($path);