From 5f5142ff583dfdc9ae82b01177c839f164bce2dc Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Wed, 9 Feb 2022 10:49:32 +0100 Subject: [PATCH] Don't provide favorite activity settings Since mails and notifications are only available for actions of other users it does not make sense to allow changing this. It also prevents the common misunderstanding with "file was changed inside a favorited folder" Signed-off-by: Joas Schilling --- apps/files/lib/Activity/Settings/FavoriteAction.php | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/apps/files/lib/Activity/Settings/FavoriteAction.php b/apps/files/lib/Activity/Settings/FavoriteAction.php index 8c43b68ef8835..3c6ceb2395916 100644 --- a/apps/files/lib/Activity/Settings/FavoriteAction.php +++ b/apps/files/lib/Activity/Settings/FavoriteAction.php @@ -55,7 +55,7 @@ public function getPriority() { * @since 11.0.0 */ public function canChangeStream() { - return true; + return false; } /** @@ -71,7 +71,7 @@ public function isDefaultEnabledStream() { * @since 11.0.0 */ public function canChangeMail() { - return true; + return false; } /** @@ -81,4 +81,12 @@ public function canChangeMail() { public function isDefaultEnabledMail() { return false; } + + /** + * @return bool True when the option can be changed for the notification + * @since 20.0.0 + */ + public function canChangeNotification() { + return false; + } }