From a15c473ae269005938a20f2567c33e7e3554a3b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=B4me=20Chilliet?= <come.chilliet@nextcloud.com>
Date: Tue, 3 Jun 2025 14:04:34 +0200
Subject: [PATCH] feat(tests): Test application enabling/disabling and routes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
---
 .github/workflows/integration-sqlite.yml      |  1 +
 build/integration/config/behat.yml            | 12 ++++-
 .../features/bootstrap/RoutingContext.php     | 18 +++++++
 .../routing_features/apps-and-routes.feature  | 52 +++++++++++++++++++
 4 files changed, 82 insertions(+), 1 deletion(-)
 create mode 100644 build/integration/features/bootstrap/RoutingContext.php
 create mode 100644 build/integration/routing_features/apps-and-routes.feature

diff --git a/.github/workflows/integration-sqlite.yml b/.github/workflows/integration-sqlite.yml
index b067ff75674ba..32d49c06c112a 100644
--- a/.github/workflows/integration-sqlite.yml
+++ b/.github/workflows/integration-sqlite.yml
@@ -66,6 +66,7 @@ jobs:
           - 'openldap_numerical_features'
           - 'ldap_features'
           - 'remoteapi_features'
+          - 'routing_features'
           - 'setup_features'
           - 'sharees_features'
           - 'sharing_features'
diff --git a/build/integration/config/behat.yml b/build/integration/config/behat.yml
index 45db510583891..f619216e6f88c 100644
--- a/build/integration/config/behat.yml
+++ b/build/integration/config/behat.yml
@@ -253,4 +253,14 @@ default:
             admin:
               - admin
               - admin
-            regular_user_password: 123456
\ No newline at end of file
+            regular_user_password: 123456
+    routing:
+      paths:
+        - "%paths.base%/../routing_features"
+      contexts:
+        - RoutingContext:
+            baseUrl: http://localhost:8080
+            admin:
+              - admin
+              - admin
+            regular_user_password: 123456
diff --git a/build/integration/features/bootstrap/RoutingContext.php b/build/integration/features/bootstrap/RoutingContext.php
new file mode 100644
index 0000000000000..37cbbb0cdee52
--- /dev/null
+++ b/build/integration/features/bootstrap/RoutingContext.php
@@ -0,0 +1,18 @@
+<?php
+/**
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+use Behat\Behat\Context\Context;
+use Behat\Behat\Context\SnippetAcceptingContext;
+
+require __DIR__ . '/../../vendor/autoload.php';
+
+class RoutingContext implements Context, SnippetAcceptingContext {
+	use Provisioning;
+	use AppConfiguration;
+	use CommandLine;
+
+	protected function resetAppConfigs(): void {
+	}
+}
diff --git a/build/integration/routing_features/apps-and-routes.feature b/build/integration/routing_features/apps-and-routes.feature
new file mode 100644
index 0000000000000..954ea73bfacf3
--- /dev/null
+++ b/build/integration/routing_features/apps-and-routes.feature
@@ -0,0 +1,52 @@
+# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+# SPDX-License-Identifier: AGPL-3.0-or-later
+Feature: appmanagement
+  Background:
+    Given using api version "2"
+    And user "user1" exists
+    And user "user2" exists
+    And group "group1" exists
+    And user "user1" belongs to group "group1"
+
+  Scenario: Enable app and test route
+    Given As an "admin"
+    And sending "DELETE" to "/cloud/apps/weather_status"
+    And app "weather_status" is disabled
+    When sending "GET" to "/apps/weather_status/api/v1/location"
+    Then the OCS status code should be "998"
+    And the HTTP status code should be "404"
+    When sending "POST" to "/cloud/apps/weather_status"
+    Then the OCS status code should be "200"
+    And the HTTP status code should be "200"
+    And app "weather_status" is enabled
+    When sending "GET" to "/apps/weather_status/api/v1/location"
+    Then the OCS status code should be "200"
+    And the HTTP status code should be "200"
+    Given As an "user1"
+    When sending "GET" to "/apps/weather_status/api/v1/location"
+    Then the OCS status code should be "200"
+    And the HTTP status code should be "200"
+    Given As an "user2"
+    When sending "GET" to "/apps/weather_status/api/v1/location"
+    Then the OCS status code should be "200"
+    And the HTTP status code should be "200"
+
+  Scenario: Enable app only for some groups
+    Given As an "admin"
+    And sending "DELETE" to "/cloud/apps/weather_status"
+    And app "weather_status" is disabled
+    When sending "GET" to "/apps/weather_status/api/v1/location"
+    Then the OCS status code should be "998"
+    And the HTTP status code should be "404"
+    Given invoking occ with "app:enable weather_status --groups group1"
+    Then the command was successful
+    Given As an "user2"
+    When sending "GET" to "/apps/weather_status/api/v1/location"
+    Then the HTTP status code should be "412"
+    Given As an "user1"
+    When sending "GET" to "/apps/weather_status/api/v1/location"
+    Then the OCS status code should be "200"
+    And the HTTP status code should be "200"
+    Given As an "admin"
+    And sending "DELETE" to "/cloud/apps/weather_status"
+    And app "weather_status" is disabled