From f5f6ed664d248829c56aac4af3a54909e61216d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Thu, 21 Dec 2017 00:25:30 +0100
Subject: [PATCH] Hide stay logged in checkbox when flow authentication is used
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 core/Controller/LoginController.php           |  1 +
 core/templates/login.php                      |  2 ++
 tests/Core/Controller/LoginControllerTest.php | 33 +++++++++++++++++++
 3 files changed, 36 insertions(+)

diff --git a/core/Controller/LoginController.php b/core/Controller/LoginController.php
index e87e097e4237e..e53095a7de7be 100644
--- a/core/Controller/LoginController.php
+++ b/core/Controller/LoginController.php
@@ -179,6 +179,7 @@ public function showLoginForm($user, $redirect_url, $remember_login) {
 
 		$parameters['alt_login'] = OC_App::getAlternativeLogIns();
 		$parameters['rememberLoginState'] = !empty($remember_login) ? $remember_login : 0;
+		$parameters['hideRemeberLoginState'] = !empty($redirect_url) && $this->session->exists('client.flow.state.token');
 
 		if (!is_null($user) && $user !== '') {
 			$parameters['loginName'] = $user;
diff --git a/core/templates/login.php b/core/templates/login.php
index 82827bbef0384..d28c92e36efd7 100644
--- a/core/templates/login.php
+++ b/core/templates/login.php
@@ -70,6 +70,7 @@
 		<?php } ?>
 
 		<div class="login-additional">
+			<?php if (!$_['hideRemeberLoginState']) { ?>
 			<div class="remember-login-container">
 				<?php if ($_['rememberLoginState'] === 0) { ?>
 				<input type="checkbox" name="remember_login" value="1" id="remember_login" class="checkbox checkbox--white">
@@ -78,6 +79,7 @@
 				<?php } ?>
 				<label for="remember_login"><?php p($l->t('Stay logged in')); ?></label>
 			</div>
+			<?php } ?>
 			<?php if (!empty($_['canResetPassword'])) { ?>
 			<div class="lost-password-container">
 				<a id="lost-password" href="<?php p($_['resetPasswordLink']); ?>">
diff --git a/tests/Core/Controller/LoginControllerTest.php b/tests/Core/Controller/LoginControllerTest.php
index e02b8403a2a71..ddf7a865d66da 100644
--- a/tests/Core/Controller/LoginControllerTest.php
+++ b/tests/Core/Controller/LoginControllerTest.php
@@ -182,12 +182,43 @@ public function testShowLoginFormWithErrorsInSession() {
 				'alt_login' => [],
 				'rememberLoginState' => 0,
 				'resetPasswordLink' => null,
+				'hideRemeberLoginState' => false,
 			],
 			'guest'
 		);
 		$this->assertEquals($expectedResponse, $this->loginController->showLoginForm('', '', ''));
 	}
 
+	public function testShowLoginFormForFlowAuth() {
+		$this->userSession
+			->expects($this->once())
+			->method('isLoggedIn')
+			->willReturn(false);
+		$this->session
+			->expects($this->once())
+			->method('exists')
+			->with('client.flow.state.token')
+			->willReturn(true);
+
+		$expectedResponse = new TemplateResponse(
+			'core',
+			'login',
+			[
+				'messages' => [],
+				'redirect_url' => 'login/flow',
+				'loginName' => '',
+				'user_autofocus' => true,
+				'canResetPassword' => true,
+				'alt_login' => [],
+				'rememberLoginState' => 0,
+				'resetPasswordLink' => null,
+				'hideRemeberLoginState' => true,
+			],
+			'guest'
+		);
+		$this->assertEquals($expectedResponse, $this->loginController->showLoginForm('', 'login/flow', ''));
+	}
+
 	/**
 	 * @return array
 	 */
@@ -240,6 +271,7 @@ public function testShowLoginFormWithPasswordResetOption($canChangePassword,
 				'alt_login' => [],
 				'rememberLoginState' => 0,
 				'resetPasswordLink' => false,
+				'hideRemeberLoginState' => false,
 			],
 			'guest'
 		);
@@ -278,6 +310,7 @@ public function testShowLoginFormForUserNamedNull() {
 				'alt_login' => [],
 				'rememberLoginState' => 0,
 				'resetPasswordLink' => false,
+				'hideRemeberLoginState' => false,
 			],
 			'guest'
 		);