From ed5f66f11aa43aa2462c450e247a25793326b69a Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Fri, 29 Dec 2017 14:07:00 +0100 Subject: [PATCH] Do no run SyncJob in cron Fixes #7184 The SyncJob can be very resource intensive. Since it requests all users on the system to create the system addressbook. In order to do this it creates a vcard for every user and updates the addressbook. There is no need for this job since the proper signals are emitted and handled in the carddav backend to update the addressbook live. Worst comes to worst there is always the occ command to bring the address book in sync again. Signed-off-by: Roeland Jago Douma --- apps/dav/appinfo/info.xml | 5 +--- apps/dav/lib/CardDAV/SyncJob.php | 42 -------------------------------- 2 files changed, 1 insertion(+), 46 deletions(-) delete mode 100644 apps/dav/lib/CardDAV/SyncJob.php diff --git a/apps/dav/appinfo/info.xml b/apps/dav/appinfo/info.xml index 2d9f73b3f43ea..b4e136f039b33 100644 --- a/apps/dav/appinfo/info.xml +++ b/apps/dav/appinfo/info.xml @@ -5,7 +5,7 @@ WebDAV endpoint AGPL owncloud.org - 1.3.0 + 1.3.1 @@ -17,9 +17,6 @@ - - OCA\DAV\CardDAV\SyncJob - OCA\DAV\Migration\FixBirthdayCalendarComponent diff --git a/apps/dav/lib/CardDAV/SyncJob.php b/apps/dav/lib/CardDAV/SyncJob.php deleted file mode 100644 index f0f8d51c2ca77..0000000000000 --- a/apps/dav/lib/CardDAV/SyncJob.php +++ /dev/null @@ -1,42 +0,0 @@ - - * @author Thomas Müller - * - * @license AGPL-3.0 - * - * This code is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License, version 3, - * as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License, version 3, - * along with this program. If not, see - * - */ - -namespace OCA\DAV\CardDAV; - -use OC\BackgroundJob\TimedJob; -use OCA\DAV\AppInfo\Application; - -class SyncJob extends TimedJob { - - public function __construct() { - // Run once a day - $this->setInterval(24 * 60 * 60); - } - - protected function run($argument) { - $app = new Application(); - /** @var SyncService $ss */ - $ss = $app->getSyncService(); - $ss->syncInstance(); - } -}