From 0579529145d2aec9ef31aab051530085775e62a2 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Fri, 4 May 2018 16:11:24 +0200 Subject: [PATCH 1/2] Reset the value when changing the check class (because it might be invalid) Signed-off-by: Joas Schilling --- apps/workflowengine/js/admin.js | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/workflowengine/js/admin.js b/apps/workflowengine/js/admin.js index ab122a8cd650b..3a453befb8b6f 100644 --- a/apps/workflowengine/js/admin.js +++ b/apps/workflowengine/js/admin.js @@ -248,6 +248,7 @@ var check = OCA.WorkflowEngine.getCheckByClass(value); if (!_.isUndefined(check)) { checks[id]['operator'] = check['operators'][0]['operator']; + checks[id]['value'] = ''; } } // model change will trigger render From a134bf7349bf8d94bdd0b617d33250d2fac45c73 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Fri, 4 May 2018 16:11:56 +0200 Subject: [PATCH 2/2] Do not error when the tag does not exist Signed-off-by: Joas Schilling --- apps/workflowengine/js/filesystemtagsplugin.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/workflowengine/js/filesystemtagsplugin.js b/apps/workflowengine/js/filesystemtagsplugin.js index dc6f608d85a3e..e66a35b73b948 100644 --- a/apps/workflowengine/js/filesystemtagsplugin.js +++ b/apps/workflowengine/js/filesystemtagsplugin.js @@ -63,7 +63,9 @@ }, formatSelection: function (tagId) { var tag = OC.SystemTags.collection.get(tagId); - return OC.SystemTags.getDescriptiveTag(tag); + if (!_.isUndefined(tag)) { + return OC.SystemTags.getDescriptiveTag(tag); + } }, escapeMarkup: function(m) { return m;