From bbdbf8a5f317e6a7e9a8edf8cd251bc27b83743e Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Wed, 1 Mar 2023 02:54:14 -0500 Subject: [PATCH] fix: Don't attempt to catch SIGQUIT or SIGKILL SIGKILL can't be caught so there's no point in trying. SIGQUIT is intended as a harsh exit for debugging purposes; it should generate a core dump that accurately depicts the program's state at the time the SIGQUIT was received. --- internal/generator/generator.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/generator/generator.go b/internal/generator/generator.go index 6f0d08df..15814932 100644 --- a/internal/generator/generator.go +++ b/internal/generator/generator.go @@ -110,7 +110,7 @@ func (g *generator) generateFromSignals() { switch sig { case syscall.SIGHUP: g.generateFromContainers() - case syscall.SIGQUIT, syscall.SIGKILL, syscall.SIGTERM, syscall.SIGINT: + case syscall.SIGTERM, syscall.SIGINT: // exit when context is done return } @@ -164,7 +164,7 @@ func (g *generator) generateAtInterval() { case sig := <-sigChan: log.Printf("Received signal: %s\n", sig) switch sig { - case syscall.SIGQUIT, syscall.SIGKILL, syscall.SIGTERM, syscall.SIGINT: + case syscall.SIGTERM, syscall.SIGINT: ticker.Stop() return } @@ -296,7 +296,7 @@ func (g *generator) generateFromEvents() { case sig := <-sigChan: log.Printf("Received signal: %s\n", sig) switch sig { - case syscall.SIGQUIT, syscall.SIGKILL, syscall.SIGTERM, syscall.SIGINT: + case syscall.SIGTERM, syscall.SIGINT: // close all watchers and exit for _, watcher := range watchers { close(watcher) @@ -471,7 +471,7 @@ func (g *generator) getContainers() ([]*context.RuntimeContainer, error) { func newSignalChannel() <-chan os.Signal { sig := make(chan os.Signal, 1) - signal.Notify(sig, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT) + signal.Notify(sig, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM) return sig }