-
-
Notifications
You must be signed in to change notification settings - Fork 2k
wip(store): migrate testing suite from jest to vitest #5036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
wip(store): migrate testing suite from jest to vitest #5036
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
✅ Deploy Preview for ngrx-site-v19 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
exequiel09
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-comment
|
Only type errors are left which I didn't touch and just appeared when migrated to
Thinking of how to fix this 🤔
|
| vi.spyOn(dispatcher, 'next'); | ||
| vi.spyOn(dispatcher, 'error'); | ||
|
|
||
| store.next(<any>1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source for 1 of the remaining errors. There's a check in the utils file and throws error if type property of action is not present which leads to this error: https://github.com/ngrx/platform/actions/runs/19849232805/job/56872554303?pr=5036#step:8:382
|
Would love to ask for some feedback on the PR @markostanimirovic and @brandonroberts especially on the issues that arised upon migrating to |
3dc8463 to
e881ed4
Compare
…previous test run
e881ed4 to
2922a93
Compare

PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current behavior is that tests are running perfectly fine on
jest. This PR ensures that it runs smoothly onvitestwithout any errors.Closes #5018
What is the new behavior?
No new behavior. Just ensures to maintain parity when it runs using
vitestDoes this PR introduce a breaking change?
Other information