From 2f185c1ebb2b4e6fa207b504b3ea155388901478 Mon Sep 17 00:00:00 2001 From: Brad Keryan Date: Thu, 14 Nov 2024 11:56:59 -0600 Subject: [PATCH 1/2] PR template: Add checkboxes for changelog and tests --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 500dce08e..a6b83690b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,14 @@ TODO: Check the above box with an 'x' indicating you've read and followed [CONTRIBUTING.md](https://github.com/ni/nidaqmx-python/blob/master/CONTRIBUTING.md). +- [ ] I've updated [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md) if applicable. + +TODO: Check the above box with an 'x' if considered if there were any and then documented client facing changes in [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md). Strike through if this is not a relevant client facing change. + +- [ ] I've added tests applicable for this pull request + +TODO: Check the above box with an 'x' indicating you have considered and added any applicable system or unit tests. Strike through if you considered and decided additional tests were not warranted. + ### What does this Pull Request accomplish? TODO: Include high-level description of the changes in this pull request. @@ -12,4 +20,4 @@ TODO: Justify why this contribution should be part of the project. ### What testing has been done? -TODO: Detail what testing has been done to ensure this submission meets requirements. \ No newline at end of file +TODO: Detail what testing has been done to ensure this submission meets requirements. From bddba26a1f2900f2dc94acf21e8dff2eea373a92 Mon Sep 17 00:00:00 2001 From: Brad Keryan Date: Thu, 14 Nov 2024 11:59:26 -0600 Subject: [PATCH 2/2] PR template: Fix repo links --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a6b83690b..a30e23d6c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,9 +2,9 @@ TODO: Check the above box with an 'x' indicating you've read and followed [CONTRIBUTING.md](https://github.com/ni/nidaqmx-python/blob/master/CONTRIBUTING.md). -- [ ] I've updated [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md) if applicable. +- [ ] I've updated [CHANGELOG.md](https://github.com/ni/nidaqmx-python/blob/master/CHANGELOG.md) if applicable. -TODO: Check the above box with an 'x' if considered if there were any and then documented client facing changes in [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md). Strike through if this is not a relevant client facing change. +TODO: Check the above box with an 'x' if considered if there were any and then documented client facing changes in [CHANGELOG.md](https://github.com/ni/nidaqmx-python/blob/master/CHANGELOG.md). Strike through if this is not a relevant client facing change. - [ ] I've added tests applicable for this pull request