Revert "feat: support oracledb (#13)" (#16)

This reverts commit 9a4443b.

Author: zhmushan

README.md

@@ -21,7 +21,7 @@ we currently supports the following SQL drives:
 - [x] mysql
 - [x] mysql2
 - [x] sqlite3
-- [x] oracledb
+- [ ] oracledb
 - [x] mssql
 
 ## Installation

src/adapter.ts

@@ -19,7 +19,7 @@ import type * as mysql from 'mysql';
 import type * as mysql2 from 'mysql2/promise';
 import type * as sqlite3 from 'sqlite3';
 import type * as mssql from 'mssql';
-import type * as oracledb from 'oracledb';
+// import type * as oracledb from 'oracledb';
 
 import { Helper } from 'casbin';
 import * as Knex from 'knex';
@@ -33,7 +33,6 @@ export type Instance = {
   mysql2: Promise<mysql2.Connection>;
   sqlite3: sqlite3.Database;
   mssql: mssql.ConnectionPool;
-  oracledb: Promise<oracledb.Connection>;
 };
 
 const CasbinRuleTable = 'casbin_rule';
@@ -104,13 +103,13 @@ export class BasicAdapter<T extends keyof Instance> implements Adapter {
     return true;
   }
 
-  async addPolicy(_sec: string, ptype: string, rule: string[]): Promise<void> {
+  async addPolicy(sec: string, ptype: string, rule: string[]): Promise<void> {
     const line = this.savePolicyLine(ptype, rule);
     await this.query(this.knex.insert(line).into(CasbinRuleTable).toQuery());
   }
 
   async addPolicies(
-    _sec: string,
+    sec: string,
     ptype: string,
     rules: string[][]
   ): Promise<void> {
@@ -127,7 +126,7 @@ export class BasicAdapter<T extends keyof Instance> implements Adapter {
   }
 
   async removePolicy(
-    _sec: string,
+    sec: string,
     ptype: string,
     rule: string[]
   ): Promise<void> {
@@ -138,7 +137,7 @@ export class BasicAdapter<T extends keyof Instance> implements Adapter {
   }
 
   async removePolicies(
-    _sec: string,
+    sec: string,
     ptype: string,
     rules: string[][]
   ): Promise<void> {
@@ -155,7 +154,7 @@ export class BasicAdapter<T extends keyof Instance> implements Adapter {
   }
 
   async removeFilteredPolicy(
-    _sec: string,
+    sec: string,
     ptype: string,
     fieldIndex: number,
     ...fieldValues: string[]
@@ -216,11 +215,6 @@ export class BasicAdapter<T extends keyof Instance> implements Adapter {
       case 'mssql': {
         await (<BasicAdapter<'mssql'>>this).client.close();
 
-        break;
-      }
-      case 'oracledb': {
-        await (await (<BasicAdapter<'oracledb'>>this).client).close();
-
         break;
       }
     }
@@ -308,11 +302,6 @@ export class BasicAdapter<T extends keyof Instance> implements Adapter {
       case 'mssql': {
         await (<BasicAdapter<'mssql'>>this).client.connect();
 
-        break;
-      }
-      case 'oracledb': {
-        await (<BasicAdapter<'oracledb'>>this).client;
-
         break;
       }
     }
@@ -363,15 +352,6 @@ export class BasicAdapter<T extends keyof Instance> implements Adapter {
         result = ((await (<BasicAdapter<'mssql'>>this).client.query(sql))
           .recordset as unknown) as CasbinRule[] | undefined;
 
-        break;
-      }
-      case 'oracledb': {
-        result = (
-          await (await (<BasicAdapter<'oracledb'>>this).client).execute<
-            CasbinRule
-          >(sql)
-        ).rows;
-
         break;
       }
     }