Skip to content

Commit af31d33

Browse files
Simplify the management of alpine version
1 parent 1e68152 commit af31d33

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

Dockerfile-alpine.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM alpine:3.4
1+
FROM alpine:0.0
22

33
ENV NODE_VERSION 0.0.0
44

config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
baseuri https://nodejs.org/dist
2+
alpine_version 3.7

update.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ function update_node_version() {
2828
shift
2929
local dockerfile=$1
3030
shift
31-
local variant
31+
local variant=""
3232
if [[ $# -eq 1 ]]; then
3333
variant=$1
3434
shift
@@ -59,12 +59,9 @@ function update_node_version() {
5959
sed -E -i.bak "/$pattern/d" "$dockerfile" && rm "$dockerfile".bak
6060
done
6161

62-
if [[ "${version/.*/}" -ge 10 ]]; then
63-
sed -E -i.bak 's/FROM (.*)alpine:3.4/FROM \1alpine:3.7/' "$dockerfile"
64-
rm "$dockerfile.bak"
65-
elif [[ "${version/.*/}" -ge 8 || "$arch" == "ppc64le" || "$arch" == "s390x" || "$arch" == "arm64" || "$arch" == "arm32v7" ]]; then
66-
sed -E -i.bak 's/FROM (.*)alpine:3.4/FROM \1alpine:3.6/' "$dockerfile"
67-
rm "$dockerfile.bak"
62+
if [ "${variant}" = "alpine" ]; then
63+
alpine_version=$(get_config "./" "alpine_version")
64+
sed -E -i.bak "s/(alpine:)0.0/\\1${alpine_version}/" "$dockerfile" && rm "$dockerfile".bak
6865
fi
6966
)
7067
}

0 commit comments

Comments
 (0)