First shot at pushing GH update from Jenkins

Author: phillipj

lib/poll-jenkins.js

@@ -0,0 +1,80 @@
+'use strict'
+
+const githubClient = require('./github-client')
+
+const jenkinsToGhStatusMap = {
+  'SUCCESS': {
+    state: 'success',
+    message: 'all tests passed'
+  },
+  'FAILURE': {
+    state: 'failure',
+    message: 'build failure'
+  },
+  'ABORTED': {
+    state: 'error',
+    message: 'build aborted'
+  },
+  'UNSTABLE': {
+    state: 'error',
+    message: 'build unstable'
+  }
+}
+
+const rxDisplayName = /node\-test\-commit\-(\w+)/
+
+function pushJenkinsUpdate (options, build) {
+  const statusOpts = extendWithBuildData(options, build)
+  const createGhStatus = createGhStatusFn(statusOpts)
+  const isPending = build.result === null
+  const matchedGhStatus = jenkinsToGhStatusMap[build.result]
+
+  if (isPending) {
+    createGhStatus('pending', 'build in progress')
+  } else if (matchedGhStatus) {
+    createGhStatus(matchedGhStatus.state, matchedGhStatus.message)
+  } else {
+    console.error(`! ${prInfoStr(options)} Unknown Jenkins build result '${build.result}'`)
+  }
+}
+
+function createGhStatusFn (options) {
+  const prInfo = prInfoStr(options)
+
+  return (state, message) => {
+    githubClient.statuses.create({
+      user: options.owner,
+      repo: options.repoName,
+      sha: options.sha,
+      target_url: options.url,
+      context: options.context,
+      state: state,
+      description: message
+    }, (err, res) => {
+      if (err) {
+        return console.error(`! ${prInfo} Error while updating Jenkins / GitHub PR status`, err)
+      }
+      console.log(`* ${prInfo} Jenkins / Github PR status updated to '${state}'`)
+    })
+  }
+}
+
+function extendWithBuildData (options, build) {
+  const lastChangeSet = build.changeSet.items[0]
+
+  return Object.assign({
+    sha: lastChangeSet.commitId,
+    url: build.url,
+    context: jobNameToStatusCtx(build.fullDisplayName)
+  }, options)
+}
+
+function jobNameToStatusCtx (displayName) {
+  return rxDisplayName.exec(displayName)[1]
+}
+
+function prInfoStr (options) {
+  return `${options.owner}/${options.repoName}`
+}
+
+module.exports = pushJenkinsUpdate

lib/push-jenkins-update.js

@@ -19,7 +19,6 @@
     "express": "^4.13.4",
     "github": "^0.2.4",
     "glob": "^7.0.3",
-    "request": "^2.72.0",
     "travis-ci": "^2.1.0"
   },
   "devDependencies": {

package.json

@@ -1,17 +1,13 @@
 'use strict'
 
-const pollJenkins = require('../lib/poll-jenkins')
+const pushJenkinsUpdate = require('../lib/push-jenkins-update')
 
 module.exports = function (app) {
-  // to trigger polling manually
-  app.get('/jenkins/:prId', (req, res) => {
-    const prId = req.params.prId
-
-    pollJenkins({
-      owner: 'nodejs',
-      repoName: 'node',
-      prId: parseInt(prId, 10)
-    })
+  app.post('/node/jenkins', (req, res) => {
+    pushJenkinsUpdate({
+      owner: 'TestOrgPleaseIgnore',
+      repoName: 'node'
+    }, req.body)
 
     res.end()
   })

scripts/node-jenkins-status.js

@@ -0,0 +1,12 @@
+{
+    "fullDisplayName": "node-test-commit-arm #3087",
+    "result": "FAILURE",
+    "changeSet": {
+        "items": [
+            {
+                "commitId": "7190bd23810f0880d95605bf6f785224a345d477"
+            }
+        ]
+    },
+    "url": "https://ci.nodejs.org/job/node-test-commit-arm/3087/"
+}

test/_fixtures/error-payload.json

@@ -0,0 +1,12 @@
+{
+    "fullDisplayName": "node-test-commit-linux #3176",
+    "result": null,
+    "changeSet": {
+        "items": [
+            {
+                "commitId": "7190bd23810f0880d95605bf6f785224a345d477"
+            }
+        ]
+    },
+    "url": "https://ci.nodejs.org/job/node-test-commit-linux/3176/"
+}

test/_fixtures/pending-payload.json

@@ -0,0 +1,12 @@
+{
+    "fullDisplayName": "node-test-commit-osx #3157",
+    "result": "SUCCESS",
+    "changeSet": {
+        "items": [
+            {
+                "commitId": "7190bd23810f0880d95605bf6f785224a345d477"
+            }
+        ]
+    },
+    "url": "https://ci.nodejs.org/job/node-test-commit-osx/3157/"
+}