diff --git a/lib/node-labels.js b/lib/node-labels.js index 478ed337..b5530923 100644 --- a/lib/node-labels.js +++ b/lib/node-labels.js @@ -91,9 +91,8 @@ const subSystemLabelsMap = new Map([ [/^lib\/internal\/url\.js$/, ['url-whatwg', 'dont-land-on-v4.x', 'dont-land-on-v6.x']], // All other lib/ files map directly - [/^lib\/_(\w+)_\w+\.js?$/, '$1'], // e.g. _(stream)_wrap [/^lib(\/internal)?\/(\w+)\.js?$/, '$2'], // other .js files - [/^lib\/internal\/(\w+)(?:\/|$)/, '$1'] // internal subfolders + [/^lib\/internal\/(\w+)(?:\/|$)/, '$1'], // internal subfolders ]) const jsSubsystemList = [ diff --git a/test/unit/node-labels.test.js b/test/unit/node-labels.test.js index 4c306174..5fc14188 100644 --- a/test/unit/node-labels.test.js +++ b/test/unit/node-labels.test.js @@ -29,6 +29,17 @@ tap.test('no labels: when ./test/ and ./lib/ files has been changed', (t) => { t.end() }) +tap.test('label: correct when lib/{not internal}/ files have been changed', (t) => { + const labels = nodeLabels.resolveLabels([ + 'lib/internal/http/common.js', + 'lib/internal/tls/legacy.js' + ]) + + t.same(labels, ['http', 'tls']) + + t.end() +}) + tap.test('label: "doc" when only ./doc/ files has been changed', (t) => { const labels = nodeLabels.resolveLabels([ 'doc/api/fs.md',