From 5aaf1db57953a2d86371e4e683d9e870f8b6d058 Mon Sep 17 00:00:00 2001 From: Geoffrey Booth <456802+GeoffreyBooth@users.noreply.github.com> Date: Tue, 12 Oct 2021 14:00:47 -0700 Subject: [PATCH 1/2] 2021-10-12 --- doc/meetings/2021-10-12.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 doc/meetings/2021-10-12.md diff --git a/doc/meetings/2021-10-12.md b/doc/meetings/2021-10-12.md new file mode 100644 index 0000000..0a651c9 --- /dev/null +++ b/doc/meetings/2021-10-12.md @@ -0,0 +1,22 @@ +# Node.js Loaders Team Meeting 2021-10-12 + +## Links + +* **Recording**: https://www.youtube.com/watch?v=hxaFpjKy84E +* **GitHub Issue**: https://github.com/nodejs/loaders/issues/40 + +## Present + +* Geoffrey Booth: @GeoffreyBooth +* Antoine du Hamel: @aduh95 +* Jacob Smith: @JakobJingleheimer +* Myles Borins: @MylesBorins +* Bradley Meck: @bmeck + +## Agenda + +* module: unflag import assertions [#40250](https://github.com/nodejs/node/pull/40250) + +## Notes + +Discussion over whether assertion should be part of the module cache key or not, and consequences of one way or the other. @GeoffreyBooth will try to implement an approach where the assertions are part of the module _job,_ and checking the assertions will happen at the same time as the URL (key) is compared, effectively making it a combined key while still having one job per key. Open question of what to do when a mismatch is found. Will investigate in the open PR, and can even land with a tentative solution that can change later since JSON modules are still flagged and this is an edge case that should never happen in realistic code (two import statements resolving to the same URL, with different assertions). From e4a0b782867f4aa341e30c8f540173d922d9139a Mon Sep 17 00:00:00 2001 From: Geoffrey Booth <456802+GeoffreyBooth@users.noreply.github.com> Date: Wed, 20 Oct 2021 15:01:28 -0700 Subject: [PATCH 2/2] Update doc/meetings/2021-10-12.md Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com> --- doc/meetings/2021-10-12.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/meetings/2021-10-12.md b/doc/meetings/2021-10-12.md index 0a651c9..fb559e3 100644 --- a/doc/meetings/2021-10-12.md +++ b/doc/meetings/2021-10-12.md @@ -11,7 +11,7 @@ * Antoine du Hamel: @aduh95 * Jacob Smith: @JakobJingleheimer * Myles Borins: @MylesBorins -* Bradley Meck: @bmeck +* Bradley Farias: @bmeck ## Agenda