From 558e6e7cb1215c3022086d695698d5fbcdb381ac Mon Sep 17 00:00:00 2001 From: Gabriel Schulhof Date: Thu, 30 Mar 2023 11:07:28 -0700 Subject: [PATCH 1/2] doc: update class hierarchy for TypeTaggable Reflect in the class hierarchy that `Napi::TypeTaggable` was injected between `Napi::Object` and `Napi:External`, and their parent class, `Napi::Value`. --- doc/hierarchy.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/hierarchy.md b/doc/hierarchy.md index 68092ea24..42b1ff99d 100644 --- a/doc/hierarchy.md +++ b/doc/hierarchy.md @@ -20,7 +20,7 @@ | [`Napi::Env`][] | | | [`Napi::Error`][] | [`Napi::ObjectReference`][], [`std::exception`][] | | [`Napi::EscapableHandleScope`][] | | -| [`Napi::External`][] | [`Napi::Value`][] | +| [`Napi::External`][] | [`Napi::TypeTaggable`][] | | [`Napi::Function`][] | [`Napi::Object`][] | | [`Napi::FunctionReference`][] | [`Napi::Reference`][] | | [`Napi::HandleScope`][] | | @@ -28,7 +28,7 @@ | [`Napi::MemoryManagement`][] | | | [`Napi::Name`][] | [`Napi::Value`][] | | [`Napi::Number`][] | [`Napi::Value`][] | -| [`Napi::Object`][] | [`Napi::Value`][] | +| [`Napi::Object`][] | [`Napi::TypeTaggable`][] | | [`Napi::ObjectReference`][] | [`Napi::Reference`][] | | [`Napi::ObjectWrap`][] | [`Napi::InstanceWrap`][], [`Napi::Reference`][] | | [`Napi::Promise`][] | [`Napi::Object`][] | @@ -38,6 +38,7 @@ | [`Napi::String`][] | [`Napi::Name`][] | | [`Napi::Symbol`][] | [`Napi::Name`][] | | [`Napi::ThreadSafeFunction`][] | | +| [`Napi::TypeTaggable`][] | [`Napi::Value][] | | [`Napi::TypeError`][] | [`Napi::Error`][] | | [`Napi::TypedArray`][] | [`Napi::Object`][] | | [`Napi::TypedArrayOf`][] | [`Napi::TypedArray`][] | @@ -83,6 +84,7 @@ [`Napi::Symbol`]: ./symbol.md [`Napi::ThreadSafeFunction`]: ./threadsafe_function.md [`Napi::TypeError`]: ./type_error.md +[`Napi::TypeTaggable`]: ./type_taggable.md [`Napi::TypedArray`]: ./typed_array.md [`Napi::TypedArrayOf`]: ./typed_array_of.md [`Napi::Uint8Array`]: ./typed_array_of.md From 63352655246b4fc2ef5a99bffb856d2af97b6288 Mon Sep 17 00:00:00 2001 From: Gabriel Schulhof Date: Thu, 30 Mar 2023 11:10:59 -0700 Subject: [PATCH 2/2] doc: fix broken links --- doc/type_taggable.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/type_taggable.md b/doc/type_taggable.md index fb505477d..ebea2344b 100644 --- a/doc/type_taggable.md +++ b/doc/type_taggable.md @@ -36,3 +36,5 @@ return value is `false`. If a tag is found and it matches `type_tag`, then the return value is `true`. [`Napi::Value`]: ./value.md +[`Napi::Object`]: ./object.md +[`Napi::External`]: ./external.md