From f552652e1acad8309373b71a9a33e7c495c0ad9f Mon Sep 17 00:00:00 2001 From: Jinho Bang Date: Tue, 2 Oct 2018 09:20:11 +0900 Subject: [PATCH] Use Call() instead of MakeCallback() in AsyncWorker Change `AsyncWorker::OnOK()` and `AsyncWorker::OnError()` callbacks to **NOT** use `MakeCallback()`. An ordinary function call (`_callback::Call()`) is now correct. Refs: https://nodejs.org/api/n-api.html#n_api_napi_make_callback --- napi-inl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/napi-inl.h b/napi-inl.h index aead8b9ce..629d46b00 100644 --- a/napi-inl.h +++ b/napi-inl.h @@ -3444,11 +3444,11 @@ inline FunctionReference& AsyncWorker::Callback() { } inline void AsyncWorker::OnOK() { - _callback.MakeCallback(_receiver.Value(), std::initializer_list{}); + _callback.Call(_receiver.Value(), std::initializer_list{}); } inline void AsyncWorker::OnError(const Error& e) { - _callback.MakeCallback(_receiver.Value(), std::initializer_list{ e.Value() }); + _callback.Call(_receiver.Value(), std::initializer_list{ e.Value() }); } inline void AsyncWorker::SetError(const std::string& error) {