Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 4847602

Browse files
atulkattichakrabot
authored andcommitted
deps: update ChakraCore to chakra-core/ChakraCore@ae0a7ca8f4
[1.8>1.9] [MERGE #4622 @atulkatti] OS:14980704 Suppress incorrect TVS warning for ConcatString buffer length check. Merge pull request #4622 from atulkatti:Bug14980704.TVS.1 Suppress incorrect TVS warning for ConcatString buffer length check. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
1 parent a8ee7e9 commit 4847602

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

deps/chakrashim/core/lib/Runtime/Library/ConcatString.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ namespace Js
113113

114114
virtual void CopyVirtual(_Out_writes_(m_charLength) char16 *const buffer, StringCopyInfoStack &nestedStringTreeCopyInfos, const byte recursionDepth) override
115115
{
116+
#pragma prefast(suppress: __WARNING_POTENTIAL_BUFFER_OVERFLOW_HIGH_PRIORITY, "WDGVSO:14980704 The CopyImpl method uses GetLength() to ensure we only access m_charLength elements of buffer.")
116117
__super::CopyImpl(buffer, N, AddressOf(m_slots[0]), nestedStringTreeCopyInfos, recursionDepth);
117118
}
118119
virtual int GetRandomAccessItemsFromConcatString(Js::JavascriptString * const *& items) const
@@ -204,6 +205,7 @@ namespace Js
204205
virtual void CopyVirtual(_Out_writes_(m_charLength) char16 *const buffer, StringCopyInfoStack &nestedStringTreeCopyInfos, const byte recursionDepth) override sealed
205206
{
206207
const_cast<ConcatStringWrapping *>(this)->EnsureAllSlots();
208+
#pragma prefast(suppress: __WARNING_POTENTIAL_BUFFER_OVERFLOW_HIGH_PRIORITY, "WDGVSO:14980704 The CopyImpl method uses GetLength() to ensure we only access m_charLength elements of buffer.")
207209
__super::CopyImpl(buffer, _countof(m_slots), AddressOf(m_slots[0]), nestedStringTreeCopyInfos, recursionDepth);
208210
}
209211
virtual int GetRandomAccessItemsFromConcatString(Js::JavascriptString * const *& items) const override sealed
@@ -253,6 +255,7 @@ namespace Js
253255
virtual void CopyVirtual(_Out_writes_(m_charLength) char16 *const buffer, StringCopyInfoStack &nestedStringTreeCopyInfos, const byte recursionDepth) override
254256
{
255257
Assert(IsFilled());
258+
#pragma prefast(suppress: __WARNING_POTENTIAL_BUFFER_OVERFLOW_HIGH_PRIORITY, "WDGVSO:14980704 The CopyImpl method uses GetLength() to ensure we only access m_charLength elements of buffer.")
256259
__super::CopyImpl(buffer, slotCount, AddressOf(m_slots[0]), nestedStringTreeCopyInfos, recursionDepth);
257260
}
258261
virtual int GetRandomAccessItemsFromConcatString(Js::JavascriptString * const *& items) const

0 commit comments

Comments
 (0)