fixup! src,permission: add --allow-net permission

Author: RafaelGSS

lib/internal/process/pre_execution.js

@@ -600,6 +600,17 @@ function initializePermission() {
       }
     }
 
+    const experimentalWarnFlags = [
+      '--allow-net',
+    ];
+    for (const flag of experimentalWarnFlags) {
+      if (getOptionValue(flag)) {
+        process.emitWarning(
+          `The flag ${flag} is under experimental phase.`,
+          'ExperimentalWarning');
+      }
+    }
+
     ObjectDefineProperty(process, 'permission', {
       __proto__: null,
       enumerable: true,

src/cares_wrap.h

@@ -274,7 +274,7 @@ class QueryWrap final : public AsyncWrap {
                       nullptr);
   }
 
-  SET_INSUFFICIENT_PERMISSION_ERROR_CALLBACK(permission::PermissionScope::kNet);
+  SET_INSUFFICIENT_PERMISSION_ERROR_CALLBACK(permission::PermissionScope::kNet)
 
   void ParseError(int status) {
     CHECK_NE(status, ARES_SUCCESS);

test/parallel/test-permission-net-warning.js

@@ -0,0 +1,7 @@
+// Flags: --permission --allow-net --allow-fs-read=*
+'use strict';
+
+const common = require('../common');
+
+common.expectWarning('ExperimentalWarning',
+                     'The flag --allow-net is under experimental phase.');

test/parallel/test-permission-net-websocket.js

@@ -2,6 +2,10 @@
 'use strict';
 
 const common = require('../common');
+if (!common.hasCrypto) {
+  common.skip('no crypto');
+}
+
 const wsUrl = 'ws://nodejs.org';
 
 const ws = new WebSocket(wsUrl);