Commit 2f65b3f
deps: V8: partially cherry-pick 8953e49478
Very partial cherry-pick of upstream commit v8/v8@8953e49478 that fixes
a hang that shows up in debug builds because of a buggy sanity check
when computing relationships between command line flags.
Example of the hang:
#include "v8.h"
#include "libplatform/libplatform.h"
int main(void) {
// works: v8::V8::SetFlagsFromString("--gc-global --noincremental-marking");
v8::V8::SetFlagsFromString("--gc-global");
v8::V8::SetFlagsFromString("--noincremental-marking");
v8::V8::InitializePlatform(v8::platform::NewDefaultPlatform().release());
v8::V8::Initialize(); // hangs in ComputeFlagListHash when defined(DEBUG)
}
PR-URL: #55274
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 0999949 commit 2f65b3f
1 file changed
+5
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
| 96 | + | |
94 | 97 | | |
| 98 | + | |
95 | 99 | | |
96 | 100 | | |
| 101 | + | |
97 | 102 | | |
98 | 103 | | |
99 | 104 | | |
| |||
0 commit comments