Skip to content

Commit 3d93f39

Browse files
committed
http2: make response.end() return this
PR-URL: #18780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 8118da7 commit 3d93f39

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

doc/api/http2.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2624,11 +2624,16 @@ See [`response.socket`][].
26242624
#### response.end([data][, encoding][, callback])
26252625
<!-- YAML
26262626
added: v8.4.0
2627+
changes:
2628+
- version: REPLACEME
2629+
pr-url: https://github.com/nodejs/node/pull/18780
2630+
description: This method now returns a reference to `ServerResponse`.
26272631
-->
26282632

26292633
* `data` {string|Buffer}
26302634
* `encoding` {string}
26312635
* `callback` {Function}
2636+
* Returns: {this}
26322637

26332638
This method signals to the server that all of the response headers and body
26342639
have been sent; that server should consider this message complete.

lib/internal/http2/compat.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -596,6 +596,8 @@ class Http2ServerResponse extends Stream {
596596
this[kFinish]();
597597
else
598598
stream.end();
599+
600+
return this;
599601
}
600602

601603
destroy(err) {

test/parallel/test-http2-compat-serverrequest-end.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ server.listen(0, common.mustCall(function() {
2626

2727
server.close();
2828
}));
29-
response.end();
29+
assert.strictEqual(response.end(), response);
3030
}));
3131
}));
3232

0 commit comments

Comments
 (0)