Skip to content

Commit 4a96a50

Browse files
alexkozyjasnell
authored andcommitted
inspector: migrate node to js_protocol.pdl
On inspector side we are going to deprecate .json protocol definition formation and replace it with new .pdl format. New format allows us to use multiline commends and contains less noise in comparision then .json. PR-URL: #20141 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@keybase.io>
1 parent 392ed93 commit 4a96a50

File tree

1 file changed

+22
-1
lines changed

1 file changed

+22
-1
lines changed

node.gyp

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,11 +681,32 @@
681681
'conditions': [
682682
[ 'v8_enable_inspector==1', {
683683
'actions': [
684+
{
685+
'action_name': 'v8_inspector_copy_protocol_to_intermediate_folder',
686+
'inputs': [ 'deps/v8/src/inspector/js_protocol.pdl' ],
687+
'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl' ],
688+
'action': [ 'cp', '<@(_inputs)', '<(SHARED_INTERMEDIATE_DIR)' ],
689+
},
690+
{
691+
'action_name': 'v8_inspector_convert_protocol_to_json',
692+
'inputs': [
693+
'<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl',
694+
],
695+
'outputs': [
696+
'<(SHARED_INTERMEDIATE_DIR)/js_protocol.json',
697+
],
698+
'action': [
699+
'python',
700+
'deps/v8/third_party/inspector_protocol/ConvertProtocolToJSON.py',
701+
'<@(_inputs)',
702+
'<@(_outputs)',
703+
],
704+
},
684705
{
685706
'action_name': 'v8_inspector_compress_protocol_json',
686707
'process_outputs_as_sources': 1,
687708
'inputs': [
688-
'deps/v8/src/inspector/js_protocol.json',
709+
'<(SHARED_INTERMEDIATE_DIR)/js_protocol.json',
689710
],
690711
'outputs': [
691712
'<(SHARED_INTERMEDIATE_DIR)/v8_inspector_protocol_json.h',

0 commit comments

Comments
 (0)