Skip to content

Commit 5989869

Browse files
committed
src: fix useless call in permission.cc
FromMaybe() has no side effects and the return value is ignored. Use Check() instead to ensure that the operation succeeded.
1 parent 347215e commit 5989869

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/permission/permission.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,15 +143,15 @@ void Permission::ThrowAccessDenied(Environment* env,
143143
PermissionToString(perm),
144144
v8::NewStringType::kNormal)
145145
.ToLocalChecked())
146-
.FromMaybe(false);
146+
.Check();
147147
err.As<Object>()
148148
->Set(env->context(),
149149
env->resource_string(),
150150
v8::String::NewFromUtf8(env->isolate(),
151151
std::string(res).c_str(),
152152
v8::NewStringType::kNormal)
153153
.ToLocalChecked())
154-
.FromMaybe(false);
154+
.Check();
155155
env->isolate()->ThrowException(err);
156156
}
157157

0 commit comments

Comments
 (0)