Skip to content

Commit 644a85d

Browse files
backestargos
authored andcommitted
Remove deprecated wasm type check
This removes uses of the "IsWebAssemblyCompiledModule" method, which is deprecated in V8 v8.1 and will be removed in v8.2. We could replace it by "IsWasmModuleObject", but since it's unused in node anyway, I just remove the definition.
1 parent 51a1b15 commit 644a85d

File tree

2 files changed

+18
-16
lines changed

2 files changed

+18
-16
lines changed

doc/api/util.md

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1867,21 +1867,6 @@ Returns `true` if the value is a built-in [`WeakSet`][] instance.
18671867
util.types.isWeakSet(new WeakSet()); // Returns true
18681868
```
18691869

1870-
### `util.types.isWebAssemblyCompiledModule(value)`
1871-
<!-- YAML
1872-
added: v10.0.0
1873-
-->
1874-
1875-
* `value` {any}
1876-
* Returns: {boolean}
1877-
1878-
Returns `true` if the value is a built-in [`WebAssembly.Module`][] instance.
1879-
1880-
```js
1881-
const module = new WebAssembly.Module(wasmBuffer);
1882-
util.types.isWebAssemblyCompiledModule(module); // Returns true
1883-
```
1884-
18851870
## Deprecated APIs
18861871

18871872
The following APIs are deprecated and should no longer be used. Existing
@@ -2333,6 +2318,24 @@ const util = require('util');
23332318
util.log('Timestamped message.');
23342319
```
23352320

2321+
### `util.types.isWebAssemblyCompiledModule(value)`
2322+
<!-- YAML
2323+
added: v10.0.0
2324+
deprecated: v14.0.0
2325+
-->
2326+
2327+
> Stability: 0 - Deprecated: Use `value instanceof WebAssembly.Module` instead.
2328+
2329+
* `value` {any}
2330+
* Returns: {boolean}
2331+
2332+
Returns `true` if the value is a built-in [`WebAssembly.Module`][] instance.
2333+
2334+
```js
2335+
const module = new WebAssembly.Module(wasmBuffer);
2336+
util.types.isWebAssemblyCompiledModule(module); // Returns true
2337+
```
2338+
23362339
[`'uncaughtException'`]: process.html#process_event_uncaughtexception
23372340
[`'warning'`]: process.html#process_event_warning
23382341
[`Array.isArray()`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray

src/node_types.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ namespace {
3535
V(DataView) \
3636
V(SharedArrayBuffer) \
3737
V(Proxy) \
38-
V(WebAssemblyCompiledModule) \
3938
V(ModuleNamespaceObject) \
4039

4140

0 commit comments

Comments
 (0)