test: fix common.canCreateSymLink() on non-Windows

Masashi Hirano · MylesBorins · commit 73f2dabf7d05 · 2018-05-08T14:22:25.000-07:00
test/common/README.md indicates that canCreateSymlink() always returns true on non-Windows platforms. However, prior to this commit, undefined was being returned. This commit aligns the implementation with the docs by returning true. PR-URL: #20511 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/test/common/index.js b/test/common/index.js
@@ -518,6 +518,8 @@ exports.canCreateSymLink = function() {
       return false;
     }
   }
+  // On non-Windows platforms, this always returns `true`
+  return true;
 };
 
 exports.getCallSite = function getCallSite(top) {

Original file line number	Diff line number	Diff line change
`@@ -518,6 +518,8 @@ exports.canCreateSymLink = function() {`
`518`	`518`	`return false;`
`519`	`519`	`}`
`520`	`520`	`}`
	`521`	+ // On non-Windows platforms, this always returns `true`
	`522`	`+ return true;`
`521`	`523`	`};`
`522`	`524`
`523`	`525`	`exports.getCallSite = function getCallSite(top) {`