src: fix -Winconsistent-missing-override warning

cjihrig · targos · commit 7a5954ef26c4 · 2020-02-13T08:42:46.000+01:00
This commit addresses the following warning: ../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] v8::Maybe<bool> mark_arraybuffer_as_untransferable( ^ ../src/js_native_api_v8.h:42:27: note: overridden virtual function is here virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable( PR-URL: #30549 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
diff --git a/src/node_api.cc b/src/node_api.cc
@@ -26,7 +26,7 @@ struct node_napi_env__ : public napi_env__ {
   }
 
   v8::Maybe<bool> mark_arraybuffer_as_untransferable(
-      v8::Local<v8::ArrayBuffer> ab) const {
+      v8::Local<v8::ArrayBuffer> ab) const override {
     return ab->SetPrivate(
         context(),
         node_env()->arraybuffer_untransferable_private_symbol(),

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ struct node_napi_env__ : public napi_env__ {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`v8::Maybe<bool> mark_arraybuffer_as_untransferable(`
`29`		`- v8::Local<v8::ArrayBuffer> ab) const {`
	`29`	`+ v8::Local<v8::ArrayBuffer> ab) const override {`
`30`	`30`	`return ab->SetPrivate(`
`31`	`31`	`context(),`
`32`	`32`	`node_env()->arraybuffer_untransferable_private_symbol(),`