src: add HandleScope to fix error

ryzokuken · jasnell · commit 80de8302e0d9 · 2018-04-16T16:15:10.000-07:00
Add `HandleError`s to the AsyncScope constructor and destructor in async_wrap-inl.h to fix "FATAL ERROR" incurring observed while running test-http2-respond-with-file using the --trace-events-enabled flag. Fixes: #19921 PR-URL: #19972 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/async_wrap-inl.h b/src/async_wrap-inl.h
@@ -50,13 +50,15 @@ inline AsyncWrap::AsyncScope::AsyncScope(AsyncWrap* wrap)
   Environment* env = wrap->env();
   if (env->async_hooks()->fields()[Environment::AsyncHooks::kBefore] == 0)
     return;
+  v8::HandleScope handle_scope(env->isolate());
   EmitBefore(env, wrap->get_async_id());
 }
 
 inline AsyncWrap::AsyncScope::~AsyncScope() {
   Environment* env = wrap_->env();
   if (env->async_hooks()->fields()[Environment::AsyncHooks::kAfter] == 0)
     return;
+  v8::HandleScope handle_scope(env->isolate());
   EmitAfter(env, wrap_->get_async_id());
 }
 

Original file line number	Diff line number	Diff line change
`@@ -50,13 +50,15 @@ inline AsyncWrap::AsyncScope::AsyncScope(AsyncWrap* wrap)`
`50`	`50`	`Environment* env = wrap->env();`
`51`	`51`	`if (env->async_hooks()->fields()[Environment::AsyncHooks::kBefore] == 0)`
`52`	`52`	`return;`
	`53`	`+ v8::HandleScope handle_scope(env->isolate());`
`53`	`54`	`EmitBefore(env, wrap->get_async_id());`
`54`	`55`	`}`
`55`	`56`
`56`	`57`	`inline AsyncWrap::AsyncScope::~AsyncScope() {`
`57`	`58`	`Environment* env = wrap_->env();`
`58`	`59`	`if (env->async_hooks()->fields()[Environment::AsyncHooks::kAfter] == 0)`
`59`	`60`	`return;`
	`61`	`+ v8::HandleScope handle_scope(env->isolate());`
`60`	`62`	`EmitAfter(env, wrap_->get_async_id());`
`61`	`63`	`}`
`62`	`64`