Skip to content

Commit 864fe99

Browse files
committed
deps: make V8 9.1 abi-compatible with 9.0
Revert "[api] Avoid handles for const API functions" This reverts commit aee471b2ff5b1a9e622426454885b748d226535b. Revert "[api] Remove deprecated [Shared]ArrayBuffer API" This reverts commit 578f6be77fc5d8af975005c2baf918e7225abb62. Revert "[Jobs]: Cleanup in v8 platform." This reverts commit baf2b088dd9f585aa597459f30d71431171666e2. Revert "Skip global registration of [Shared]ArrayBuffer backing stores" This reverts commit fcdf35e6d70d51699ece063e25dc705e80673308. PR-URL: #38991 Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 6111671 commit 864fe99

File tree

12 files changed

+1030
-239
lines changed

12 files changed

+1030
-239
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.13',
39+
'v8_embedder_string': '-node.14',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-platform.h

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,9 @@ class JobDelegate {
181181
/**
182182
* Returns true if the current task is called from the thread currently
183183
* running JobHandle::Join().
184+
* TODO(etiennep): Make pure virtual once custom embedders implement it.
184185
*/
185-
virtual bool IsJoiningThread() const = 0;
186+
virtual bool IsJoiningThread() const { return false; }
186187
};
187188

188189
/**
@@ -219,21 +220,30 @@ class JobHandle {
219220
* Forces all existing workers to yield ASAP but doesn’t wait for them.
220221
* Warning, this is dangerous if the Job's callback is bound to or has access
221222
* to state which may be deleted after this call.
223+
* TODO(etiennep): Cleanup once implemented by all embedders.
222224
*/
223-
virtual void CancelAndDetach() = 0;
225+
virtual void CancelAndDetach() { Cancel(); }
224226

225227
/**
226228
* Returns true if there's any work pending or any worker running.
227229
*/
228230
virtual bool IsActive() = 0;
229231

232+
// TODO(etiennep): Clean up once all overrides are removed.
233+
V8_DEPRECATED("Use !IsActive() instead.")
234+
virtual bool IsCompleted() { return !IsActive(); }
235+
230236
/**
231237
* Returns true if associated with a Job and other methods may be called.
232238
* Returns false after Join() or Cancel() was called. This may return true
233239
* even if no workers are running and IsCompleted() returns true
234240
*/
235241
virtual bool IsValid() = 0;
236242

243+
// TODO(etiennep): Clean up once all overrides are removed.
244+
V8_DEPRECATED("Use IsValid() instead.")
245+
virtual bool IsRunning() { return IsValid(); }
246+
237247
/**
238248
* Returns true if job priority can be changed.
239249
*/
@@ -262,6 +272,10 @@ class JobTask {
262272
* it must not call back any JobHandle methods.
263273
*/
264274
virtual size_t GetMaxConcurrency(size_t worker_count) const = 0;
275+
276+
// TODO(1114823): Clean up once all overrides are removed.
277+
V8_DEPRECATED("Use the version that takes |worker_count|.")
278+
virtual size_t GetMaxConcurrency() const { return 0; }
265279
};
266280

267281
/**

0 commit comments

Comments
 (0)