Skip to content

Commit 8983405

Browse files
maclover7joyeecheung
authored andcommitted
fs: extract out validateBuffer function
PR-URL: #17682 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent fc8c1b1 commit 8983405

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

lib/fs.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,15 @@ function makeCallback(cb) {
153153
};
154154
}
155155

156+
function validateBuffer(buffer) {
157+
if (!isUint8Array(buffer)) {
158+
const err = new errors.TypeError('ERR_INVALID_ARG_TYPE', 'buffer',
159+
['Buffer', 'Uint8Array']);
160+
Error.captureStackTrace(err, validateBuffer);
161+
throw err;
162+
}
163+
}
164+
156165
function validateFd(fd) {
157166
let err;
158167

@@ -745,9 +754,7 @@ fs.openSync = function(path, flags, mode) {
745754

746755
fs.read = function(fd, buffer, offset, length, position, callback) {
747756
validateFd(fd);
748-
if (!isUint8Array(buffer))
749-
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'buffer',
750-
['Buffer', 'Uint8Array']);
757+
validateBuffer(buffer);
751758

752759
offset |= 0;
753760
length |= 0;
@@ -779,9 +786,7 @@ Object.defineProperty(fs.read, internalUtil.customPromisifyArgs,
779786

780787
fs.readSync = function(fd, buffer, offset, length, position) {
781788
validateFd(fd);
782-
if (!isUint8Array(buffer))
783-
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'buffer',
784-
['Buffer', 'Uint8Array']);
789+
validateBuffer(buffer);
785790

786791
offset |= 0;
787792
length |= 0;

0 commit comments

Comments
 (0)